Make convert function internal

Signed-off-by: Mathias L. Baumann <[email protected]>

Author: Marenz

src/frequenz/client/dispatch/_client.py

@@ -42,7 +42,7 @@
     ComponentSelector,
     Dispatch,
     DispatchEvent,
-    component_selector_to_protobuf,
+    _component_selector_to_protobuf,
 )
 
 # pylint: enable=no-name-in-module
@@ -150,7 +150,7 @@ def to_interval(
         # Setup parameters
         start_time_interval = to_interval(start_from, start_to)
         end_time_interval = to_interval(end_from, end_to)
-        selectors = list(map(component_selector_to_protobuf, component_selectors))
+        selectors = list(map(_component_selector_to_protobuf, component_selectors))
         filters = DispatchFilter(
             selectors=selectors,
             start_time_interval=start_time_interval,
@@ -338,7 +338,7 @@ async def update(
                     else:
                         msg.update.duration = round(val.total_seconds())
                 case "selector":
-                    msg.update.selector.CopyFrom(component_selector_to_protobuf(val))
+                    msg.update.selector.CopyFrom(_component_selector_to_protobuf(val))
                 case "is_active":
                     msg.update.is_active = val
                 case "payload":

src/frequenz/client/dispatch/_internal_types.py

@@ -21,8 +21,8 @@
 from .recurrence import RecurrenceRule
 from .types import (
     ComponentSelector,
-    component_selector_from_protobuf,
-    component_selector_to_protobuf,
+    _component_selector_from_protobuf,
+    _component_selector_to_protobuf,
 )
 
 # pylint: enable=no-name-in-module
@@ -97,7 +97,9 @@ def from_protobuf(
                 to_datetime(pb_object.dispatch_data.start_time)
             ),
             duration=duration,
-            selector=component_selector_from_protobuf(pb_object.dispatch_data.selector),
+            selector=_component_selector_from_protobuf(
+                pb_object.dispatch_data.selector
+            ),
             active=pb_object.dispatch_data.is_active,
             dry_run=pb_object.dispatch_data.is_dry_run,
             payload=MessageToDict(pb_object.dispatch_data.payload),
@@ -121,7 +123,7 @@ def to_protobuf(self) -> PBDispatchCreateRequest:
                 duration=(
                     round(self.duration.total_seconds()) if self.duration else None
                 ),
-                selector=component_selector_to_protobuf(self.selector),
+                selector=_component_selector_to_protobuf(self.selector),
                 is_active=self.active,
                 is_dry_run=self.dry_run,
                 payload=payload,

src/frequenz/client/dispatch/types.py

@@ -36,7 +36,7 @@
 """
 
 
-def component_selector_from_protobuf(
+def _component_selector_from_protobuf(
     pb_selector: PBComponentSelector,
 ) -> ComponentSelector:
     """Convert a protobuf component selector to a component selector.
@@ -66,7 +66,7 @@ def component_selector_from_protobuf(
             raise ValueError("Invalid component selector")
 
 
-def component_selector_to_protobuf(
+def _component_selector_to_protobuf(
     selector: ComponentSelector,
 ) -> PBComponentSelector:
     """Convert a component selector to a protobuf component selector.
@@ -181,7 +181,7 @@ def from_protobuf(cls, pb_object: PBDispatch) -> "Dispatch":
                 if pb_object.data.duration
                 else None
             ),
-            selector=component_selector_from_protobuf(pb_object.data.selector),
+            selector=_component_selector_from_protobuf(pb_object.data.selector),
             active=pb_object.data.is_active,
             dry_run=pb_object.data.is_dry_run,
             payload=MessageToDict(pb_object.data.payload),
@@ -209,7 +209,7 @@ def to_protobuf(self) -> PBDispatch:
                 duration=(
                     round(self.duration.total_seconds()) if self.duration else None
                 ),
-                selector=component_selector_to_protobuf(self.selector),
+                selector=_component_selector_to_protobuf(self.selector),
                 is_active=self.active,
                 is_dry_run=self.dry_run,
                 payload=payload,

tests/test_dispatch_types.py

@@ -15,8 +15,8 @@
 )
 from frequenz.client.dispatch.types import (
     Dispatch,
-    component_selector_from_protobuf,
-    component_selector_to_protobuf,
+    _component_selector_from_protobuf,
+    _component_selector_to_protobuf,
 )
 
 
@@ -30,8 +30,8 @@ def test_component_selector() -> None:
         [ComponentCategory.METER],
         [ComponentCategory.EV_CHARGER, ComponentCategory.BATTERY],
     ):
-        protobuf = component_selector_to_protobuf(selector)
-        assert component_selector_from_protobuf(protobuf) == selector
+        protobuf = _component_selector_to_protobuf(selector)
+        assert _component_selector_from_protobuf(protobuf) == selector
 
 
 def test_end_criteria() -> None: