Skip to content

Commit 84d5501

Browse files
authored
Fail the nox-cross-arch-all job if any matrix job fails (#43)
Otherwise this job will be skipped, just like when the matrix jobs are skipped, resulting in a passed check when it should have failed.
2 parents df4c2a3 + 1df19e0 commit 84d5501

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,9 @@ jobs:
115115
runs-on: ${{ matrix.os }}
116116

117117
steps:
118+
- name: Early failure
119+
run: "exit 1"
120+
118121
- name: Fetch sources
119122
uses: actions/checkout@v4
120123

@@ -200,10 +203,13 @@ jobs:
200203
# The job name should match the name of the `nox-cross-arch` job.
201204
name: Cross-arch tests with nox
202205
needs: ["nox-cross-arch"]
206+
if: always() && contains(needs.*.result, 'failure')
203207
runs-on: ubuntu-20.04
204208
steps:
205-
- name: Return true
206-
run: "true"
209+
- name: Fail because some cross-arch tests failed
210+
run: |
211+
echo "Error: Some cross-arch tests failed"
212+
exit 1
207213
208214
build:
209215
name: Build distribution packages

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# Fallback owner.
55
# These are the default owners for everything in the repo, unless a later match
66
# takes precedence.
7-
* @frequenz-floss/api-dispatch-team
7+
* @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team

0 commit comments

Comments
 (0)