Remove timedelta-based custom init method from DeliveryPeriod

Now the dataclass's automatic `__init__` method gets used, so a
`DeliveryDuration` instance must be provided.  If not available, it
can be produced from a `timedelta` with
`DeliveryDuration.from_timedelta()`.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

src/frequenz/client/electricity_trading/_types.py

@@ -386,54 +386,6 @@ class DeliveryPeriod:
     duration: DeliveryDuration
     """The length of the delivery period."""
 
-    def __init__(
-        self,
-        start: datetime,
-        duration: timedelta,
-    ) -> None:
-        """
-        Initialize the DeliveryPeriod object.
-
-        Args:
-            start: Start UTC timestamp represents the beginning of the delivery period.
-            duration: The length of the delivery period.
-
-        Raises:
-            ValueError: If the start timestamp does not have a timezone.
-                        or if the duration is not 5, 15, 30, or 60 minutes.
-        """
-        if start.tzinfo is None:
-            raise ValueError("Start timestamp must have a timezone.")
-        if start.tzinfo != timezone.utc:
-            _logger.warning(
-                "Start timestamp is not in UTC timezone. Converting to UTC."
-            )
-            start = start.astimezone(timezone.utc)
-        self.start = start
-
-        minutes = duration.total_seconds() / 60
-        match minutes:
-            case 5:
-                self.duration = DeliveryDuration.MINUTES_5
-            case 15:
-                self.duration = DeliveryDuration.MINUTES_15
-            case 30:
-                self.duration = DeliveryDuration.MINUTES_30
-            case 60:
-                self.duration = DeliveryDuration.MINUTES_60
-            case _:
-                raise ValueError(
-                    "Invalid duration value. Duration must be 5, 15, 30, or 60 minutes."
-                )
-
-    def __hash__(self) -> int:
-        """
-        Create hash of the DeliveryPeriod object.
-
-        Returns:
-            Hash of the DeliveryPeriod object.
-        """
-        return hash((self.start, self.duration))
 
     def __eq__(
         self,
@@ -481,27 +433,10 @@ def from_pb(cls, delivery_period: delivery_duration_pb2.DeliveryPeriod) -> Self:
 
         Returns:
             DeliveryPeriod object corresponding to the protobuf message.
-
-        Raises:
-            ValueError: If the duration is not 5, 15, 30, or 60 minutes.
         """
         start = delivery_period.start.ToDatetime(tzinfo=timezone.utc)
         delivery_duration_enum = DeliveryDuration.from_pb(delivery_period.duration)
-
-        match delivery_duration_enum:
-            case DeliveryDuration.MINUTES_5:
-                duration = timedelta(minutes=5)
-            case DeliveryDuration.MINUTES_15:
-                duration = timedelta(minutes=15)
-            case DeliveryDuration.MINUTES_30:
-                duration = timedelta(minutes=30)
-            case DeliveryDuration.MINUTES_60:
-                duration = timedelta(minutes=60)
-            case _:
-                raise ValueError(
-                    "Invalid duration value. Duration must be 5, 15, 30, or 60 minutes."
-                )
-        return cls(start=start, duration=duration)
+        return cls(start=start, duration=delivery_duration_enum)
 
     def to_pb(self) -> delivery_duration_pb2.DeliveryPeriod:
         """Convert a DeliveryPeriod object to protobuf DeliveryPeriod.

src/frequenz/client/electricity_trading/cli/etrading.py

@@ -13,6 +13,7 @@
     Client,
     Currency,
     DeliveryArea,
+    DeliveryDuration,
     DeliveryPeriod,
     EnergyMarketCodeType,
     MarketSide,
@@ -71,7 +72,7 @@ async def receive_public_trades(  # pylint: disable=too-many-arguments
         check_delivery_start(delivery_start)
         delivery_period = DeliveryPeriod(
             start=delivery_start,
-            duration=timedelta(minutes=15),
+            duration=DeliveryDuration.MINUTES_15,
         )
     stream = client.receive_public_trades(
         delivery_period=delivery_period,
@@ -111,7 +112,7 @@ async def receive_public_orders(  # pylint: disable=too-many-arguments
         check_delivery_start(delivery_start)
         delivery_period = DeliveryPeriod(
             start=delivery_start,
-            duration=timedelta(minutes=15),
+            duration=DeliveryDuration.MINUTES_15,
         )
     stream = client.receive_public_order_book(
         delivery_period=delivery_period,
@@ -151,8 +152,7 @@ async def list_gridpool_trades(
     if delivery_start is not None:
         check_delivery_start(delivery_start)
         delivery_period = DeliveryPeriod(
-            start=delivery_start,
-            duration=timedelta(minutes=15),
+            start=delivery_start, duration=DeliveryDuration.MINUTES_15
         )
     lst = client.list_gridpool_trades(gid, delivery_period=delivery_period)
 
@@ -203,7 +203,7 @@ async def list_gridpool_orders(
         check_delivery_start(delivery_start)
         delivery_period = DeliveryPeriod(
             start=delivery_start,
-            duration=timedelta(minutes=15),
+            duration=DeliveryDuration.MINUTES_15,
         )
     lst = client.list_gridpool_orders(gid, delivery_period=delivery_period)
 
@@ -265,7 +265,7 @@ async def create_order(
         ),
         delivery_period=DeliveryPeriod(
             start=delivery_start,
-            duration=duration,
+            duration=DeliveryDuration.from_timedelta(duration),
         ),
         order_type=OrderType.LIMIT,
         side=side,