Skip to content

Commit 8efbf56

Browse files
Fix cookiecutter TODOs
Signed-off-by: camille-bouvy-frequenz <[email protected]>
1 parent 829ddf6 commit 8efbf56

File tree

11 files changed

+29
-78
lines changed

11 files changed

+29
-78
lines changed

.github/ISSUE_TEMPLATE/bug.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ labels:
1111
body:
1212
- type: markdown
1313
attributes:
14-
value:
15-
Thanks for taking the time to fill out this bug report!
14+
value: Thanks for taking the time to fill out this bug report!
1615
- type: textarea
1716
id: what-happened
1817
attributes:
@@ -36,7 +35,7 @@ body:
3635
description:
3736
Please add a comma-separated list of the versions affected by this
3837
issue.
39-
placeholder: 'Example: v0.11.0, v0.12.0'
38+
placeholder: "Example: v0.11.0, v0.12.0"
4039
- type: dropdown
4140
id: part
4241
attributes:
@@ -50,9 +49,6 @@ body:
5049
- Documentation (part:docs)
5150
- Unit, integration and performance tests (part:tests)
5251
- Build script, CI, dependencies, etc. (part:tooling)
53-
# TODO(cookiecutter): Add other parts
54-
# Please have in mind that that the part:xxx labels need to
55-
# be created in the GitHub repository.
5652
validations:
5753
required: true
5854
- type: textarea

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@ blank_issues_enabled: true
55
contact_links:
66
- name: Ask a question ❓
77
url: https://github.com/frequenz-floss/frequenz-client-electricity-trading-python/discussions/new?category=support
8-
# TODO(cookiecutter): Make sure the GitHub repository has a discussion category "Support"
9-
# Rename the "Q&A" category to "Support" and change the emoji to 🆘 (SOS)
108
about: Use this if you are not sure how to do something, have installation problems, etc.

.github/keylabeler.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,3 @@ labelMappings:
1616
"part:tests": "part:tests"
1717
"part:tooling": "part:tooling"
1818
"part:❓": "part:❓"
19-
# TODO(cookiecutter): Add other parts
20-
# Please have in mind that that the part:xxx labels need to
21-
# be created in the GitHub repository.

.github/workflows/release-notes-check.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ on:
1212
- "labeled"
1313
- "unlabeled"
1414

15-
1615
jobs:
1716
check-release-notes:
1817
name: Check release notes are updated
@@ -22,8 +21,6 @@ jobs:
2221
if: github.event_name == 'pull_request'
2322
uses: brettcannon/check-for-changed-files@4170644959a21843b31f1181f2a1761d65ef4791 # v1.2.0
2423
with:
25-
# TODO(cookiecutter): Uncomment the following line for private repositories, otherwise remove it and remove it
26-
# token: ${{ secrets.github_token }}
2724
file-pattern: "RELEASE_NOTES.md"
2825
prereq-pattern: "src/**"
2926
skip-label: "cmd:skip-release-notes"

CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
# Fallback owner.
55
# These are the default owners for everything in the repo, unless a later match
66
# takes precedence.
7-
# TODO(cookiecutter): Add more specific code-owners, check if the default is correct
87
* @frequenz-floss/api-electricity-trading-team

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
Electricity Trading API client for Python
1010

11-
TODO(cookiecutter): Improve the README file
12-
1311
## Supported Platforms
1412

1513
The following platforms are officially supported (tested):

docs/_scripts/macros.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,5 @@ def define_env(env: macros.MacrosPlugin) -> None:
7777
# https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#adding-annotations
7878
env.variables["code_annotation_marker"] = _CODE_ANNOTATION_MARKER
7979

80-
# TODO(cookiecutter): Add any other macros, variables and filters here.
81-
8280
# This hook needs to be done at the end of the `define_env` function.
8381
_hook_macros_plugin(env)

mkdocs.yml

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@ site_author: "Frequenz Energy-as-a-Service GmbH"
88
copyright: "Copyright © 2024 Frequenz Energy-as-a-Service GmbH"
99
repo_name: "frequenz-client-electricity-trading-python"
1010
repo_url: "https://github.com/frequenz-floss/frequenz-client-electricity-trading-python"
11-
# TODO(cookiecutter): "main" is the GitHub repo default branch, you might want to update it
12-
# if the project uses a different default branch.
1311
edit_uri: "edit/main/docs/"
14-
strict: true # Treat warnings as errors
12+
strict: true # Treat warnings as errors
1513

1614
# Build directories
1715
theme:
1816
name: "material"
19-
# TODO(cookiecutter): You might want to change the logo, the file is located in "docs/"
2017
logo: _img/logo.png
2118
favicon: _img/logo.png
2219
language: en
@@ -35,28 +32,27 @@ theme:
3532
- navigation.tracking
3633
- toc.follow
3734
palette:
38-
- media: "(prefers-color-scheme: light)"
39-
scheme: default
40-
primary: indigo
41-
accent: deep purple
42-
toggle:
43-
icon: material/weather-sunny
44-
name: Switch to dark mode
45-
- media: "(prefers-color-scheme: dark)"
46-
scheme: slate
47-
primary: black
48-
accent: teal
49-
toggle:
50-
icon: material/weather-night
51-
name: Switch to light mode
35+
- media: "(prefers-color-scheme: light)"
36+
scheme: default
37+
primary: indigo
38+
accent: deep purple
39+
toggle:
40+
icon: material/weather-sunny
41+
name: Switch to dark mode
42+
- media: "(prefers-color-scheme: dark)"
43+
scheme: slate
44+
primary: black
45+
accent: teal
46+
toggle:
47+
icon: material/weather-night
48+
name: Switch to light mode
5249

5350
extra:
54-
# TODO(cookiecutter): You probably want to update the social links
5551
social:
56-
- icon: fontawesome/brands/github
57-
link: https://github.com/frequenz-floss
58-
- icon: fontawesome/brands/linkedin
59-
link: https://www.linkedin.com/company/frequenz-com
52+
- icon: fontawesome/brands/github
53+
link: https://github.com/frequenz-floss
54+
- icon: fontawesome/brands/linkedin
55+
link: https://www.linkedin.com/company/frequenz-com
6056
version:
6157
provider: mike
6258
default: latest
@@ -116,10 +112,10 @@ plugins:
116112
show_source: true
117113
signature_crossrefs: true
118114
import:
119-
# TODO(cookiecutter): You might want to add other external references here
120-
# See https://mkdocstrings.github.io/python/usage/#import for details
121115
- https://docs.python.org/3/objects.inv
122116
- https://typing-extensions.readthedocs.io/en/stable/objects.inv
117+
- https://frequenz-floss.github.io/frequenz-api-common/v0.3/objects.inv
118+
- https://grpc.github.io/grpc/python/objects.inv
123119
# Note this plugin must be loaded after mkdocstrings to be able to use macros
124120
# inside docstrings. See the comment in `docs/_scripts/macros.py` for more
125121
# details

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ description = "Electricity Trading API client for Python"
1515
readme = "README.md"
1616
license = { text = "MIT" }
1717
keywords = ["frequenz", "python", "lib", "library", "client-electricity-trading", "client", "api", "python", "trading", "electricity-trading"]
18-
# TODO(cookiecutter): Remove and add more classifiers if appropriate
1918
classifiers = [
2019
"Development Status :: 3 - Alpha",
2120
"Intended Audience :: Developers",
Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,4 @@
11
# License: MIT
22
# Copyright © 2024 Frequenz Energy-as-a-Service GmbH
33

4-
"""Electricity Trading API client for Python.
5-
6-
TODO(cookiecutter): Add a more descriptive module description.
7-
"""
8-
9-
10-
# TODO(cookiecutter): Remove this function
11-
def delete_me(*, blow_up: bool = False) -> bool:
12-
"""Do stuff for demonstration purposes.
13-
14-
Args:
15-
blow_up: If True, raise an exception.
16-
17-
Returns:
18-
True if no exception was raised.
19-
20-
Raises:
21-
RuntimeError: if blow_up is True.
22-
"""
23-
if blow_up:
24-
raise RuntimeError("This function should be removed!")
25-
return True
4+
"""Electricity Trading API client for Python."""

0 commit comments

Comments
 (0)