You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds integration test for the API client, service, as well as
handel. These tests are performed by creating, updating & deleting
orders on the simulation database.
As discussed in the latest team meeting, these tests were originally
written with the goal of automatising everything. As a consequence, some
of them might not be the most coherent: for instance
`test_list_public_trades()` just verifies that the returned list isn’t
null. It doesn’t check for the correctness of the output at all. These
tests might thus have to be split into system tests (that would be
performed manually), and integration test. Additionally, I think that
having these tests run by the CI is not the most appropriate (especially
given that they depend on other components than just the client).
So please suggest alternatives & improvements, & let's make a next level
robust, efficient and awesome test suite!😎
0 commit comments