Introduces CLI commands to interact with the trading API: #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwasicki
force-pushed
the
trades
branch
2 times, most recently
from
311b2ff to
c8f0693
Compare
shsms
reviewed
Jan 14, 2025
| from datetime import datetime, timedelta | ||
| from zoneinfo import ZoneInfo | ||
|
|
||
| import click |
Contributor
There was a problem hiding this comment.
This needs to go in pyproject.toml as well, I think.
|
|
||
| from frequenz.client.electricity_trading.cli.day_ahead import list_day_ahead_prices | ||
|
|
||
| TZ = ZoneInfo("Europe/Berlin") |
Contributor
There was a problem hiding this comment.
Maybe we should take it from the "TZ" environment variable and use Berlin as the default, in case we want to call the command with UTC, etc., for whatever reason.
Collaborator
Author
There was a problem hiding this comment.
I wanted to keep this since this is the timezone used on EEX and EPEX, which is what is supported for day-ahead prices.
The click library allows for more complex interactions with the CLI tool for upcoming changes that add support for interacting with the actual trading API. In future the listing of day ahead prices from the entsoe API might be moved into a separate CLI tool. Signed-off-by: cwasicki <[email protected]>
Introduces CLI commands to interact with the trading API: - `list_trades` allows listing and streaming public trades for specified delivery periods. If no delivery start is given, starts streaming all new public trades. - `list_orders` allows listing and streaming orders for specified delivery periods and gridpool IDs. If no delivery start is given, starts streaming all new orders for this gridpool ID. Signed-off-by: cwasicki <[email protected]>
Signed-off-by: cwasicki <[email protected]>
github-actions
bot
added
the
part:tooling
cwasicki
commented
Jan 14, 2025
| from datetime import datetime, timedelta | ||
| from zoneinfo import ZoneInfo | ||
|
|
||
| import click |
|
|
||
| from frequenz.client.electricity_trading.cli.day_ahead import list_day_ahead_prices | ||
|
|
||
| TZ = ZoneInfo("Europe/Berlin") |
Collaborator
Author
There was a problem hiding this comment.
I wanted to keep this since this is the timezone used on EEX and EPEX, which is what is supported for day-ahead prices.
shsms
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_tradesallows listing and streaming public trades for specified delivery periods. If no delivery start is given, starts streaming all new public trades.list_ordersallows listing and streaming orders for specified delivery periods and gridpool IDs. If no delivery start is given, starts streaming all new orders for this gridpool ID.This also changes the argument parsing for the day-ahead command to use the click library to support more complex interactions. In future the listing of day ahead prices from the entsoe API might be moved into a separate CLI tool.