Skip to content

Commit c6968c0

Browse files
committed
Disable no-name-in-module pylint rule globally
We can disable this rule because `mypy` already checks for this kind of errors and this also fixes a long-standing issue with `pylint` that can't figure out protobuf generate stuff have some members: * pylint-dev/pylint#6281 Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 8d1c8a8 commit c6968c0

File tree

9 files changed

+3
-28
lines changed

9 files changed

+3
-28
lines changed

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ disable = [
146146
"unsubscriptable-object",
147147
# Checked by mypy
148148
"no-member",
149+
"no-name-in-module",
149150
# Checked by flake8
150151
"f-string-without-interpolation",
151152
"line-too-long",

src/frequenz/client/microgrid/_client.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
from typing import Any, TypeVar, cast
1010

1111
import grpc.aio
12-
13-
# pylint: disable=no-name-in-module
1412
from frequenz.api.common.components_pb2 import ComponentCategory as PbComponentCategory
1513
from frequenz.api.common.metrics_pb2 import Bounds as PbBounds
1614
from frequenz.api.microgrid.microgrid_pb2 import ComponentData as PbComponentData
@@ -27,12 +25,10 @@
2725
SetPowerActiveParam as PbSetPowerActiveParam,
2826
)
2927
from frequenz.api.microgrid.microgrid_pb2_grpc import MicrogridStub
30-
31-
# pylint: enable=no-name-in-module
3228
from frequenz.channels import Receiver
3329
from frequenz.client.base import channel, retry, streaming
34-
from google.protobuf.empty_pb2 import Empty # pylint: disable=no-name-in-module
35-
from google.protobuf.timestamp_pb2 import Timestamp # pylint: disable=no-name-in-module
30+
from google.protobuf.empty_pb2 import Empty
31+
from google.protobuf.timestamp_pb2 import Timestamp
3632

3733
from ._component import (
3834
Component,

src/frequenz/client/microgrid/_component.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
from dataclasses import dataclass
77
from enum import Enum
88

9-
# pylint: disable=no-name-in-module
109
from frequenz.api.common.components_pb2 import ComponentCategory as PbComponentCategory
1110
from frequenz.api.microgrid.grid_pb2 import Metadata as PbGridMetadata
1211
from frequenz.api.microgrid.inverter_pb2 import Metadata as PbInverterMetadata
1312
from frequenz.api.microgrid.inverter_pb2 import Type as PbInverterType
1413

15-
# pylint: enable=no-name-in-module
16-
1714

1815
class ComponentType(Enum):
1916
"""A base class from which individual component types are derived."""

src/frequenz/client/microgrid/_component_data.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@
88
from datetime import datetime, timezone
99
from typing import Self
1010

11-
# pylint: disable=no-name-in-module
1211
from frequenz.api.microgrid.microgrid_pb2 import ComponentData as PbComponentData
1312

1413
from ._component_error import BatteryError, InverterError
15-
16-
# pylint: enable=no-name-in-module
1714
from ._component_states import (
1815
BatteryComponentState,
1916
BatteryRelayState,

src/frequenz/client/microgrid/_component_error.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,12 @@
77
from enum import Enum
88
from typing import Self
99

10-
# pylint: disable=no-name-in-module
1110
from frequenz.api.microgrid.battery_pb2 import Error as PbBatteryError
1211
from frequenz.api.microgrid.battery_pb2 import ErrorCode as PbBatteryErrorCode
1312
from frequenz.api.microgrid.common_pb2 import ErrorLevel as PbErrorLevel
1413
from frequenz.api.microgrid.inverter_pb2 import Error as PbInverterError
1514
from frequenz.api.microgrid.inverter_pb2 import ErrorCode as PbInverterErrorCode
1615

17-
# pylint: enable=no-name-in-module
18-
1916

2017
class ErrorLevel(Enum):
2118
"""Error level."""

src/frequenz/client/microgrid/_component_states.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from enum import Enum
77
from typing import Self
88

9-
# pylint: disable=no-name-in-module
109
from frequenz.api.microgrid.battery_pb2 import ComponentState as PbBatteryComponentState
1110
from frequenz.api.microgrid.battery_pb2 import RelayState as PbBatteryRelayState
1211
from frequenz.api.microgrid.ev_charger_pb2 import CableState as PbEvCableState
@@ -15,8 +14,6 @@
1514
ComponentState as PbInverterComponentState,
1615
)
1716

18-
# pylint: enable=no-name-in-module
19-
2017

2118
class BatteryComponentState(Enum):
2219
"""Component states of a battery."""

tests/test_client.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
import grpc.aio
1313
import pytest
14-
15-
# pylint: disable=no-name-in-module
1614
from frequenz.api.common.components_pb2 import ComponentCategory as PbComponentCategory
1715
from frequenz.api.common.components_pb2 import InverterType as PbInverterType
1816
from frequenz.api.common.metrics_pb2 import Bounds as PbBounds
@@ -28,8 +26,6 @@
2826
from frequenz.api.microgrid.microgrid_pb2 import (
2927
SetPowerActiveParam as PbSetPowerActiveParam,
3028
)
31-
32-
# pylint: enable=no-name-in-module
3329
from frequenz.client.base import retry
3430

3531
from frequenz.client.microgrid import (

tests/test_component.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@
44
"""Tests for the microgrid component wrapper."""
55

66
import pytest
7-
8-
# pylint: disable=no-name-in-module
97
from frequenz.api.common.components_pb2 import ComponentCategory as PbComponentCategory
108

11-
# pylint: enable=no-name-in-module
129
from frequenz.client.microgrid._component import (
1310
Component,
1411
ComponentCategory,

tests/test_component_data.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
from datetime import datetime, timezone
77

88
import pytest
9-
10-
# pylint: disable=no-name-in-module
119
from frequenz.api.common.metrics.electrical_pb2 import AC as PbAc
1210
from frequenz.api.common.metrics_pb2 import Bounds as PbBounds
1311
from frequenz.api.common.metrics_pb2 import Metric as PbMetric
@@ -21,7 +19,6 @@
2119
from frequenz.api.microgrid.microgrid_pb2 import ComponentData as PbComponentData
2220
from google.protobuf.timestamp_pb2 import Timestamp
2321

24-
# pylint: enable=no-name-in-module
2522
from frequenz.client.microgrid import (
2623
ComponentData,
2724
InverterComponentState,

0 commit comments

Comments
 (0)