Remove the timeout from the gRPC stream call #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the timeout parameter from a gRPC streaming call to prevent premature disconnections. The timeout was incorrectly applied to the entire stream duration rather than individual messages, causing issues with long-lived streaming connections that are expected to run indefinitely.
Key Changes:
- Removed the
timeout=DEFAULT_GRPC_CALL_TIMEOUTparameter from thereceive_component_data_samples_streammethod's gRPC call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
llucax
added
the
cmd:skip-release-notes
The timeout counts for the whole duration of the call, not each individual streamed message, so it always times out, as we expect this stream to basically last forever. On top of this, disconnecting the stream seems to trigger some bug in the SDK, so we better avoid it for now. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
rm-stream-timeout
branch
from
2eff085 to
1fa9aff
Compare
github-actions
bot
added
the
part:tests
tiyash-basu-frequenz
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout counts for the whole duration of the call, not each individual streamed message, so it always times out, as we expect this stream to basically last forever.
On top of this, disconnecting the stream seems to trigger some bug in the SDK, so we better avoid it for now.