Skip to content

Commit c5a4115

Browse files
committed
Use new metrics package from common client
This package is compatible with `v1alpha8` of the common API v0.8. Signed-off-by: cwasicki <[email protected]>
1 parent 2b9e9ec commit c5a4115

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

src/frequenz/client/reporting/_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
from frequenz.client.base.client import BaseApiClient
5050
from frequenz.client.base.exception import ClientNotConnected
5151
from frequenz.client.base.streaming import GrpcStreamBroadcaster
52-
from frequenz.client.common.metric import Metric
52+
from frequenz.client.common.metrics import Metric
5353
from google.protobuf.timestamp_pb2 import Timestamp as PBTimestamp
5454

5555
from ._batch_unroll_receiver import BatchUnrollReceiver
@@ -294,7 +294,7 @@ def dt2ts(dt: datetime) -> PBTimestamp:
294294
)
295295

296296
metric_conns_pb = [
297-
PBMetricConnections(metric=metric.to_proto(), connections=[])
297+
PBMetricConnections(metric=metric.value, connections=[])
298298
for metric in metrics
299299
]
300300

@@ -477,7 +477,7 @@ def dt2ts(dt: datetime) -> PBTimestamp:
477477

478478
metric_conns_pb = [
479479
PBMetricConnections(
480-
metric=metric.to_proto(),
480+
metric=metric.value,
481481
connections=[],
482482
)
483483
for metric in metrics
@@ -556,7 +556,7 @@ def receive_aggregated_data(
556556

557557
aggregation_config = PBAggregationConfig(
558558
microgrid_id=microgrid_id,
559-
metric=metric.to_proto(),
559+
metric=metric.value,
560560
aggregation_formula=aggregation_formula,
561561
)
562562

src/frequenz/client/reporting/_types.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
)
2121

2222
# pylint: enable=no-name-in-module
23-
from frequenz.client.common.metric import Metric
23+
from frequenz.client.common.metrics import Metric
2424

2525

2626
class MetricSample(NamedTuple):
@@ -92,8 +92,8 @@ def __iter__(self) -> Iterator[MetricSample]:
9292
for item in items:
9393
cid = getattr(item, self.id_attr)
9494
for sample in getattr(item, "metric_samples", []):
95-
ts = sample.sampled_at.ToDatetime().replace(tzinfo=timezone.utc)
96-
met = Metric.from_proto(sample.metric).name
95+
ts = sample.sample_time.ToDatetime().replace(tzinfo=timezone.utc)
96+
met = Metric(sample.metric).name
9797

9898
# Handle simple_metric
9999
if sample.value.HasField("simple_metric"):
@@ -126,8 +126,8 @@ def __iter__(self) -> Iterator[MetricSample]:
126126
ts, mid, cid, f"{met}_bound_{i}_upper", bound.upper
127127
)
128128

129-
for state in getattr(item, "states", []):
130-
ts = state.sampled_at.ToDatetime().replace(tzinfo=timezone.utc)
129+
for state in getattr(item, "state_snapshots", []):
130+
ts = state.origin_time.ToDatetime().replace(tzinfo=timezone.utc)
131131
for category, category_items in {
132132
"state": getattr(state, "states", []),
133133
"warning": getattr(state, "warnings", []),
@@ -150,7 +150,10 @@ def __init__(self, data_pb: PBReceiveMicrogridComponentsDataStreamResponse):
150150
data_pb: The underlying protobuf message.
151151
"""
152152
super().__init__(
153-
data_pb, id_attr="component_id", items_attr="components", has_bounds=True
153+
data_pb,
154+
id_attr="electrical_component_id",
155+
items_attr="components",
156+
has_bounds=True,
154157
)
155158

156159

src/frequenz/client/reporting/cli/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from datetime import datetime, timedelta
99
from typing import AsyncIterator
1010

11-
from frequenz.client.common.metric import Metric
11+
from frequenz.client.common.metrics import Metric
1212

1313
from frequenz.client.reporting import ReportingApiClient
1414
from frequenz.client.reporting._types import MetricSample

0 commit comments

Comments
 (0)