Skip to content

Commit d0fd5d6

Browse files
committed
Remove redundant async loops and declarations
Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 8b2af8b commit d0fd5d6

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

src/frequenz/client/reporting/_client.py

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -305,17 +305,16 @@ def transform_response(
305305
) -> ComponentsDataBatch:
306306
return ComponentsDataBatch(response)
307307

308-
async def stream_method() -> (
308+
def stream_method() -> (
309309
AsyncIterable[PBReceiveMicrogridComponentsDataStreamResponse]
310310
):
311311
call_iterator = self.stub.ReceiveMicrogridComponentsDataStream(
312312
request, metadata=self._metadata
313313
)
314-
async for response in cast(
314+
return cast(
315315
AsyncIterable[PBReceiveMicrogridComponentsDataStreamResponse],
316316
call_iterator,
317-
):
318-
yield response
317+
)
319318

320319
self._components_data_streams[stream_key] = GrpcStreamBroadcaster(
321320
stream_name="microgrid-components-data-stream",
@@ -491,17 +490,16 @@ def transform_response(
491490
) -> SensorsDataBatch:
492491
return SensorsDataBatch(response)
493492

494-
async def stream_method() -> (
493+
def stream_method() -> (
495494
AsyncIterable[PBReceiveMicrogridSensorsDataStreamResponse]
496495
):
497496
call_iterator = self.stub.ReceiveMicrogridSensorsDataStream(
498497
request, metadata=self._metadata
499498
)
500-
async for response in cast(
499+
return cast(
501500
AsyncIterable[PBReceiveMicrogridSensorsDataStreamResponse],
502501
call_iterator,
503-
):
504-
yield response
502+
)
505503

506504
self._sensors_data_streams[stream_key] = GrpcStreamBroadcaster(
507505
stream_name="microgrid-sensors-data-stream",
@@ -511,7 +509,7 @@ async def stream_method() -> (
511509

512510
return self._sensors_data_streams[stream_key].new_receiver()
513511

514-
async def receive_aggregated_data(
512+
def receive_aggregated_data(
515513
self,
516514
*,
517515
microgrid_id: int,
@@ -587,17 +585,14 @@ def transform_response(
587585
) -> MetricSample:
588586
return AggregatedMetric(response).sample()
589587

590-
async def stream_method() -> AsyncIterable[PBAggregatedStreamResponse]:
588+
def stream_method() -> AsyncIterable[PBAggregatedStreamResponse]:
591589
call_iterator = (
592590
self.stub.ReceiveAggregatedMicrogridComponentsDataStream(
593591
request, metadata=self._metadata
594592
)
595593
)
596594

597-
async for response in cast(
598-
AsyncIterable[PBAggregatedStreamResponse], call_iterator
599-
):
600-
yield response
595+
return cast(AsyncIterable[PBAggregatedStreamResponse], call_iterator)
601596

602597
self._aggregated_data_streams[stream_key] = GrpcStreamBroadcaster(
603598
stream_name="aggregated-microgrid-data-stream",

src/frequenz/client/reporting/cli/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ async def data_iter() -> AsyncIterator[MetricSample]:
171171
for formula in formulas:
172172
assert resampling_period is not None
173173
for metric in metrics:
174-
async for sample in await client.receive_aggregated_data(
174+
async for sample in client.receive_aggregated_data(
175175
microgrid_id=microgrid_id,
176176
metric=metric,
177177
aggregation_formula=formula,

0 commit comments

Comments
 (0)