Make running status methods private

They are meant to be used only by the dispatch actor.

Signed-off-by: Mathias L. Baumann <[email protected]>

Author: Marenz

src/frequenz/dispatch/_dispatch.py

@@ -83,19 +83,20 @@ def __init__(
             running_state_change_synced,
         )
 
-    def set_deleted(self) -> None:
+    def _set_deleted(self) -> None:
         """Mark the dispatch as deleted."""
         object.__setattr__(self, "deleted", True)
 
-    def running_status_notified(self) -> bool:
+    @property
+    def _running_status_notified(self) -> bool:
         """Check that the latest running state change notification was sent.
 
         Returns:
             True if the latest running state change notification was sent, False otherwise.
         """
         return self.running_state_change_synced == self.update_time
 
-    def set_running_status_notified(self) -> None:
+    def _set_running_status_notified(self) -> None:
         """Mark the latest running state change notification as sent."""
         object.__setattr__(self, "running_state_change_synced", self.update_time)
 

src/frequenz/dispatch/actor.py

@@ -119,7 +119,7 @@ async def _fetch(self) -> None:
 
         for dispatch in old_dispatches.values():
             _logger.info("Deleted dispatch: %s", dispatch)
-            dispatch.set_deleted()
+            dispatch._set_deleted()  # pylint: disable=protected-access
             await self._lifecycle_updates_sender.send(Deleted(dispatch=dispatch))
             if task := self._scheduled.pop(dispatch.id, None):
                 task.cancel()
@@ -214,7 +214,8 @@ def _running_state_change(
             assert updated_dispatch is not None
 
             # Client was not informed about the dispatch, do it now
-            if not updated_dispatch.running_status_notified():
+            # pylint: disable=protected-access
+            if not updated_dispatch._running_status_notified:
                 return True
 
         # Deleted dispatch
@@ -252,4 +253,4 @@ async def _send_running_state_change(self, dispatch: Dispatch) -> None:
         await self._running_state_change_sender.send(dispatch)
         # Update the last sent notification time
         # so we know if this change was already sent
-        dispatch.set_running_status_notified()
+        dispatch._set_running_status_notified()  # pylint: disable=protected-access