Clean up API a bit #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Jan 20, 2025
Marenz
commented
- Update example to new code
- Update component selector example
- Remove now unnessecary check & parameter
- Make dispatch receiving less chatty/verbose
github-actions
bot
added
part:tests
llucax
previously approved these changes
Jan 21, 2025
| my_actor = MyActor(dispatch_updates_channel.new_receiver()) | ||
| status_receiver = dispatcher.running_status_change.new_receiver() | ||
| status_receiver = dispatcher.new_running_state_event_receiver("EXAMPLE_TYPE") |
There was a problem hiding this comment.
Why wasn't this picked up by tests? 🤔
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Mathias L. Baumann <[email protected]>
fixes frequenz-floss#68 Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
managing
branch
2 times, most recently
from
9a354b5 to
3c3204a
Compare
github-actions
bot
added
the
part:tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.