-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add data processing module #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.x.x
Are you sure you want to change the base?
feat: Add data processing module #146
Conversation
7a1284d to
2a87545
Compare
51c056a to
3c0c281
Compare
3c0c281 to
6af0c82
Compare
99b7fd6 to
8c09dc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to have a separate module which clearly defines every new metric or KPI. These could be implemented as a function for each of these, which takes all relevant series as input arguments and returns the corresponding series or scalar, resp.
Then the reporting module provides a single function that takes the data frame received from this as input and creates a data frame with new columns just using these functions.
Similarly further KPIs or data frames which do not share the same time index can be derived from that new data frame.
What do you think @Mohammad-Tayyab-Frequenz?
8c09dc2 to
b568150
Compare
b568150 to
028368a
Compare
fefb080 to
968ad19
Compare
968ad19 to
3d899c6
Compare
3d899c6 to
c95c243
Compare
Signed-off-by: Mohammad Tayyab <[email protected]>
Signed-off-by: Mohammad Tayyab <[email protected]>
Signed-off-by: Mohammad Tayyab <[email protected]>
Signed-off-by: Mohammad Tayyab <[email protected]>
c95c243 to
bc37412
Compare
No description provided.