Skip to content

Conversation

@Mohammad-Tayyab-Frequenz
Copy link
Contributor

No description provided.

@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz requested a review from a team as a code owner August 28, 2025 17:21
@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz added cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation labels Aug 28, 2025
@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz force-pushed the add-data-processing-module branch 3 times, most recently from 51c056a to 3c0c281 Compare September 8, 2025 08:31
@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz removed the cmd:skip-release-notes It is not necessary to update release notes for this PR label Sep 8, 2025
@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz force-pushed the add-data-processing-module branch 3 times, most recently from 99b7fd6 to 8c09dc2 Compare September 8, 2025 12:22
Copy link
Contributor

@cwasicki cwasicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have a separate module which clearly defines every new metric or KPI. These could be implemented as a function for each of these, which takes all relevant series as input arguments and returns the corresponding series or scalar, resp.

Then the reporting module provides a single function that takes the data frame received from this as input and creates a data frame with new columns just using these functions.

Similarly further KPIs or data frames which do not share the same time index can be derived from that new data frame.

What do you think @Mohammad-Tayyab-Frequenz?

@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Sep 17, 2025
@Mohammad-Tayyab-Frequenz Mohammad-Tayyab-Frequenz force-pushed the add-data-processing-module branch 6 times, most recently from fefb080 to 968ad19 Compare September 19, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants