Skip to content

Make sybil test init files #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make sybil test init files #19

wants to merge 1 commit into from

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Oct 2, 2024

No description provided.

@Marenz Marenz requested a review from a team as a code owner October 2, 2024 12:30
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Oct 2, 2024
@Marenz Marenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Oct 2, 2024
@Marenz
Copy link
Contributor Author

Marenz commented Oct 2, 2024 

❰marenz❙~/frequenz/frequenz-quantities-python(gitinitsybil)❱✔≻ pytest
===================================================================================== test session starts =====================================================================================
platform linux -- Python 3.11.9, pytest-8.2.2, pluggy-1.5.0
rootdir: /home/marenz/frequenz/frequenz-quantities-python
configfile: pyproject.toml
testpaths: tests, src
plugins: asyncio-0.23.7, mock-3.14.0, hypothesis-6.104.2
asyncio: mode=Mode.AUTO
collected 206 items

tests/test_quantities.py .............................................................................................................................................................. [ 76%]
..............................................                                                                                                                                          [ 99%]
src/frequenz/quantities/__init__.py .                                                                                                                                                   [ 99%]
src/frequenz/quantities/_quantity.py .                                                                                                                                                  [100%]

==================================================================================== 206 passed in 12.73s =====================================================================================
❰

llucax
llucax reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried adding an error to the example in __init__.py and was properly detected. I would say we close this and make the changes directly in repo-config.

@Marenz
Copy link
Contributor Author

Marenz commented Oct 2, 2024

I am still wondering if a certain complexity of imports could cause problems...

@llucax
Copy link
Contributor

llucax commented Oct 2, 2024

Maybe try it in the SDK and channels repos too? Those are probably the repos with more files and more examples.

@Marenz
Make sybil test init files
1ff4c0b 
Signed-off-by: Mathias L. Baumann <[email protected]>
@llucax
Copy link
Contributor

llucax commented Oct 21, 2024

I think this was confirmed to work correctly now. Should we just go and fix repo-config instead and make a patch release with the fix so it is propagated to all repos automatically instead of adding this hack?

@llucax
Copy link
Contributor

llucax commented Oct 21, 2024

Haha, I wrote almost the same comment 3 weeks ago. Let's go for it in repo-config. If it doesn't work for some complex repo, we can always rollback, but keep adding this hack to more and more repos will make the rolling back much more complicated than handling it indirectly via repo-config.

@Marenz
Copy link
Contributor Author

Marenz commented Oct 28, 2024

frequenz-floss/frequenz-repo-config-python#321

@Marenz Marenz closed this Oct 28, 2024
@Marenz Marenz deleted the initsybil branch October 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax left review comments

@daniel-zullo-frequenz daniel-zullo-frequenz Awaiting requested review from daniel-zullo-frequenz daniel-zullo-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marenz @llucax