Skip to content

Commit 0916f1b

Browse files
Fetch submodules when doing cross-arch tests (#225)
We need to do that because if the project has submodules, they need to be available when running the tests in the container too.
2 parents e2bae45 + eb09fb4 commit 0916f1b

File tree

7 files changed

+25
-0
lines changed
  • cookiecutter/{{cookiecutter.github_repo_name}}/.github/workflows
  • tests_golden/integration/test_cookiecutter_generation
    • actor/frequenz-actor-test/.github/workflows
    • api/frequenz-api-test/.github/workflows
    • app/frequenz-app-test/.github/workflows
    • lib/frequenz-test-python/.github/workflows
    • model/frequenz-model-test/.github/workflows

7 files changed

+25
-0
lines changed

RELEASE_NOTES.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,15 @@ To upgrade without regenerating the project, you can follow these steps:
8484
COPY dist dist
8585
RUN pip install dist/*.whl && \
8686
EOF
87+
88+
- If your repository uses submodules and do cross-arch tests, you need to update the `nox-cross-arch` job in the `.github/workflows/ci.yaml` workflow and add the option `submodules: true` to the `checkout` action, for example:
89+
90+
```yaml
91+
steps:
92+
- name: Fetch sources
93+
uses: actions/checkout@v4
94+
with:
95+
submodules: recursive
8796
```
8897
8998
## New Features
@@ -103,4 +112,8 @@ To upgrade without regenerating the project, you can follow these steps:
103112
104113
### Cookiecutter template
105114
115+
<<<<<<< HEAD
106116
- Fix the `test-installation` CI job when dependencies in `pyproject.toml` contain git URLs.
117+
=======
118+
- Fix cross-arch testing for respositories with submodules.
119+
>>>>>>> ed6cc5f (Fetch submodules when doing cross-arch tests)

cookiecutter/{{cookiecutter.github_repo_name}}/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ jobs:
143143
steps:
144144
- name: Fetch sources
145145
uses: actions/checkout@v4
146+
with:
147+
submodules: true
146148

147149
- name: Set up QEMU
148150
uses: docker/setup-qemu-action@v3

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ jobs:
117117
steps:
118118
- name: Fetch sources
119119
uses: actions/checkout@v4
120+
with:
121+
submodules: true
120122

121123
- name: Set up QEMU
122124
uses: docker/setup-qemu-action@v3

tests_golden/integration/test_cookiecutter_generation/api/frequenz-api-test/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ jobs:
140140
steps:
141141
- name: Fetch sources
142142
uses: actions/checkout@v4
143+
with:
144+
submodules: true
143145

144146
- name: Set up QEMU
145147
uses: docker/setup-qemu-action@v3

tests_golden/integration/test_cookiecutter_generation/app/frequenz-app-test/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ jobs:
117117
steps:
118118
- name: Fetch sources
119119
uses: actions/checkout@v4
120+
with:
121+
submodules: true
120122

121123
- name: Set up QEMU
122124
uses: docker/setup-qemu-action@v3

tests_golden/integration/test_cookiecutter_generation/lib/frequenz-test-python/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ jobs:
117117
steps:
118118
- name: Fetch sources
119119
uses: actions/checkout@v4
120+
with:
121+
submodules: true
120122

121123
- name: Set up QEMU
122124
uses: docker/setup-qemu-action@v3

tests_golden/integration/test_cookiecutter_generation/model/frequenz-model-test/.github/workflows/ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ jobs:
117117
steps:
118118
- name: Fetch sources
119119
uses: actions/checkout@v4
120+
with:
121+
submodules: true
120122

121123
- name: Set up QEMU
122124
uses: docker/setup-qemu-action@v3

0 commit comments

Comments
 (0)