Skip to content

Commit 2bbb99c

Browse files
authored
Fix minor issues in some comments (#167)
- ci: Improve description of the arm64 `Dockerfile` - Fix typo in `docs/_css/style.css` - Update release notes
2 parents 5e3b038 + 69a8996 commit 2bbb99c

File tree

21 files changed

+40
-41
lines changed

21 files changed

+40
-41
lines changed

.github/containers/nox-cross-arch/arm64-ubuntu-20.04-python-3.11.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# License: MIT
22
# Copyright © 2023 Frequenz Energy-as-a-Service GmbH
33

4-
# This Dockerfile is used to test the installation of the python package in
5-
# multiple platforms in the CI. It is not used to build the package itself.
4+
# This Dockerfile is used to run the tests in arm64, which is not supported by
5+
# GitHub Actions at the moment.
66

77
FROM docker.io/library/ubuntu:20.04
88

RELEASE_NOTES.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,28 @@
11
# Frequenz Repository Configuration Release Notes
22

3-
## Summary
4-
5-
<!-- Here goes a general summary of what this release is about -->
6-
73
## Upgrading
84

9-
<!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with -->
10-
115
### Cookiecutter template
126

13-
<!-- Here upgrade steps for cookiecutter specifically -->
7+
Instead of regenerating the templates, you can simply:
148

15-
## New Features
9+
- Run this command to fix the typo and wrong `cli` package:
1610

17-
<!-- Here goes the main new features and examples or instructions on how to use them -->
11+
```sh
12+
sed -i 's/annothations/annotations/' docs/_css/style.css
13+
sed -i 's/frequenz\.repo\.config\.cli\.version\.mkdocs\.sort/frequenz.repo.config.cli.version.mike.sort/' .github/workflows/ci.yaml
14+
```
1815

19-
### Cookiecutter template
16+
- Replace the comment after the copyright notice in `.github/containers/nox-cross-arch/arm64-ubuntu-20.04-python-3.11.Dockerfile` with:
2017

21-
- Show a link to the documentation in PyPI.
18+
```Dockerfile
19+
# This Dockerfile is used to run the tests in arm64, which is not supported by
20+
# GitHub Actions at the moment.
21+
```
2222

2323
## Bug Fixes
2424

25-
<!-- Here goes notable bug fixes that are worth a special mention or explanation -->
26-
2725
### Cookiecutter template
2826

29-
<!-- Here bug fixes for cookiecutter specifically -->
27+
- docs: Fix typo in `docs/_css/style.css` ("annothations" -> "annotations")
28+
- ci: Fix the description of the arm64 `Dockerfile`

cookiecutter/{{cookiecutter.github_repo_name}}/.github/containers/nox-cross-arch/arm64-ubuntu-20.04-python-3.11.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# Copyright © {% now 'utc', '%Y' %} {{cookiecutter.author_name}}
33
{% raw -%}
44

5-
# This Dockerfile is used to run the tests in architectures not supported by
6-
# GitHub Actions.
5+
# This Dockerfile is used to run the tests in arm64, which is not supported by
6+
# GitHub Actions at the moment.
77

88
FROM docker.io/library/ubuntu:20.04
99

cookiecutter/{{cookiecutter.github_repo_name}}/.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ jobs:
391391
if: steps.mike-version.outputs.version
392392
run: |
393393
git checkout gh-pages
394-
python -m frequenz.repo.config.cli.version.mkdocs.sort versions.json
394+
python -m frequenz.repo.config.cli.version.mike.sort versions.json
395395
git commit -a -m "Sort versions.json"
396396
397397
- name: Publish site

cookiecutter/{{cookiecutter.github_repo_name}}/docs/_css/style.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ a.external:hover::after, a.md-nav__link[href^="https:"]:hover::after {
2929

3030
/* Code annotations with numbers.
3131
*
32-
* Normally annothations are shown with a (+) button that expands the
32+
* Normally annotations are shown with a (+) button that expands the
3333
* annotation. To be able to explain code step by step, it is good to have
3434
* annotations with numbers, to be able to follow the notes in a particular
3535
* order.

docs/_css/style.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ a.external:hover::after, a.md-nav__link[href^="https:"]:hover::after {
2929

3030
/* Code annotations with numbers.
3131
*
32-
* Normally annothations are shown with a (+) button that expands the
32+
* Normally annotations are shown with a (+) button that expands the
3333
* annotation. To be able to explain code step by step, it is good to have
3434
* annotations with numbers, to be able to follow the notes in a particular
3535
* order.

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/.github/containers/nox-cross-arch/arm64-ubuntu-20.04-python-3.11.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# License: MIT
22
# Copyright © 2023 Frequenz Energy-as-a-Service GmbH
3-
# This Dockerfile is used to run the tests in architectures not supported by
4-
# GitHub Actions.
3+
# This Dockerfile is used to run the tests in arm64, which is not supported by
4+
# GitHub Actions at the moment.
55

66
FROM docker.io/library/ubuntu:20.04
77

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ jobs:
363363
if: steps.mike-version.outputs.version
364364
run: |
365365
git checkout gh-pages
366-
python -m frequenz.repo.config.cli.version.mkdocs.sort versions.json
366+
python -m frequenz.repo.config.cli.version.mike.sort versions.json
367367
git commit -a -m "Sort versions.json"
368368
369369
- name: Publish site

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/docs/_css/style.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ a.external:hover::after, a.md-nav__link[href^="https:"]:hover::after {
2929

3030
/* Code annotations with numbers.
3131
*
32-
* Normally annothations are shown with a (+) button that expands the
32+
* Normally annotations are shown with a (+) button that expands the
3333
* annotation. To be able to explain code step by step, it is good to have
3434
* annotations with numbers, to be able to follow the notes in a particular
3535
* order.

tests_golden/integration/test_cookiecutter_generation/api/frequenz-api-test/.github/containers/nox-cross-arch/arm64-ubuntu-20.04-python-3.11.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# License: MIT
22
# Copyright © 2023 Frequenz Energy-as-a-Service GmbH
3-
# This Dockerfile is used to run the tests in architectures not supported by
4-
# GitHub Actions.
3+
# This Dockerfile is used to run the tests in arm64, which is not supported by
4+
# GitHub Actions at the moment.
55

66
FROM docker.io/library/ubuntu:20.04
77

0 commit comments

Comments
 (0)