Skip to content

Commit 9cea866

Browse files
authored
Disable some pylint checks that are checked by other tools (#280)
2 parents a1204fb + 2f86dfc commit 9cea866

File tree

9 files changed

+35
-1
lines changed

9 files changed

+35
-1
lines changed

RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
- The `Markdown` dependency was bumped so we don't need to add a `type: ignore` due to incorrect type hints.
4242
- The generated docs now show the symbol type in the table of contents.
4343
- The dependecies were updated to the latest versions.
44+
- Disabled some `pylint` checks that are already checked by other tools.
4445

4546
## Bug Fixes
4647

cookiecutter/migrate.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,5 +80,14 @@ sed -i \
8080
run: test "$DEPS_RESULT" = "success"' \
8181
.github/workflows/ci.yaml
8282

83+
echo "========================================================================"
84+
85+
echo "Disabling some pylint checks also checked by other tools"
86+
sed -i -e '/ "unsubscriptable-object",/a \ # Checked by mypy\
87+
"no-member",' \
88+
-e '/ # Checked by flake8/a \ "f-string-without-interpolation",' \
89+
-e '/ "line-too-long",/a \ "missing-function-docstring",' \
90+
pyproject.toml
91+
8392
# Add a separation line like this one after each migration step.
8493
echo "========================================================================"

cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,12 @@ disable = [
165165
# pylint's unsubscriptable check is buggy and is not needed because
166166
# it is a type-check, for which we already have mypy.
167167
"unsubscriptable-object",
168+
# Checked by mypy
169+
"no-member",
168170
# Checked by flake8
171+
"f-string-without-interpolation",
169172
"line-too-long",
173+
"missing-function-docstring",
170174
"redefined-outer-name",
171175
"unnecessary-lambda-assignment",
172176
"unused-import",

mkdocs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ plugins:
9595
- literate-nav:
9696
nav_file: SUMMARY.md
9797
- mike:
98-
alias_type: redirect
98+
alias_type: symlink
9999
canonical_version: latest
100100
- mkdocstrings:
101101
default_handler: python

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,12 @@ disable = [
139139
# pylint's unsubscriptable check is buggy and is not needed because
140140
# it is a type-check, for which we already have mypy.
141141
"unsubscriptable-object",
142+
# Checked by mypy
143+
"no-member",
142144
# Checked by flake8
145+
"f-string-without-interpolation",
143146
"line-too-long",
147+
"missing-function-docstring",
144148
"redefined-outer-name",
145149
"unnecessary-lambda-assignment",
146150
"unused-import",

tests_golden/integration/test_cookiecutter_generation/api/frequenz-api-test/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,12 @@ disable = [
134134
# pylint's unsubscriptable check is buggy and is not needed because
135135
# it is a type-check, for which we already have mypy.
136136
"unsubscriptable-object",
137+
# Checked by mypy
138+
"no-member",
137139
# Checked by flake8
140+
"f-string-without-interpolation",
138141
"line-too-long",
142+
"missing-function-docstring",
139143
"redefined-outer-name",
140144
"unnecessary-lambda-assignment",
141145
"unused-import",

tests_golden/integration/test_cookiecutter_generation/app/frequenz-app-test/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,12 @@ disable = [
138138
# pylint's unsubscriptable check is buggy and is not needed because
139139
# it is a type-check, for which we already have mypy.
140140
"unsubscriptable-object",
141+
# Checked by mypy
142+
"no-member",
141143
# Checked by flake8
144+
"f-string-without-interpolation",
142145
"line-too-long",
146+
"missing-function-docstring",
143147
"redefined-outer-name",
144148
"unnecessary-lambda-assignment",
145149
"unused-import",

tests_golden/integration/test_cookiecutter_generation/lib/frequenz-test-python/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,12 @@ disable = [
135135
# pylint's unsubscriptable check is buggy and is not needed because
136136
# it is a type-check, for which we already have mypy.
137137
"unsubscriptable-object",
138+
# Checked by mypy
139+
"no-member",
138140
# Checked by flake8
141+
"f-string-without-interpolation",
139142
"line-too-long",
143+
"missing-function-docstring",
140144
"redefined-outer-name",
141145
"unnecessary-lambda-assignment",
142146
"unused-import",

tests_golden/integration/test_cookiecutter_generation/model/frequenz-model-test/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,12 @@ disable = [
139139
# pylint's unsubscriptable check is buggy and is not needed because
140140
# it is a type-check, for which we already have mypy.
141141
"unsubscriptable-object",
142+
# Checked by mypy
143+
"no-member",
142144
# Checked by flake8
145+
"f-string-without-interpolation",
143146
"line-too-long",
147+
"missing-function-docstring",
144148
"redefined-outer-name",
145149
"unnecessary-lambda-assignment",
146150
"unused-import",

0 commit comments

Comments
 (0)