Skip to content

Commit cbd22e4

Browse files
committed
Split dependencies for app and actor/model
Actors and models are libraries, so they should provide ranges of dependencies, but apps should always have their dependencies pinned. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 093603b commit cbd22e4

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,22 @@ classifiers = [
4242
]
4343
requires-python = ">= 3.11, < 4"
4444
# TODO(cookiecutter): Remove and add more dependencies if appropriate
45-
{%- if cookiecutter.type in ("app", "actor", "model") %}
45+
{%- if cookiecutter.type in ("actor", "model") %}
4646
dependencies = [
47-
"typing-extensions == 4.12.2",
47+
"typing-extensions >= 4.12.2, < 5",
4848
# Make sure to update the version for cross-referencing also in the
4949
# mkdocs.yml file when changing the version here (look for the config key
5050
# plugins.mkdocstrings.handlers.python.import)
5151
"frequenz-sdk >= 1.0.0rc1300, < 1.0.0rc1400",
5252
]
53+
{%- elif cookiecutter.type == "app" %}
54+
dependencies = [
55+
"typing-extensions == 4.12.2",
56+
# Make sure to update the version for cross-referencing also in the
57+
# mkdocs.yml file when changing the version here (look for the config key
58+
# plugins.mkdocstrings.handlers.python.import)
59+
"frequenz-sdk == 1.0.0rc1300",
60+
]
5361
{%- elif cookiecutter.type == "api" %}
5462
dependencies = [
5563
"frequenz-api-common >= 0.6.2, < 0.7.0",

tests_golden/integration/test_cookiecutter_generation/actor/frequenz-actor-test/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ classifiers = [
2828
requires-python = ">= 3.11, < 4"
2929
# TODO(cookiecutter): Remove and add more dependencies if appropriate
3030
dependencies = [
31-
"typing-extensions == 4.12.2",
31+
"typing-extensions => 4.12.2, < 5",
3232
# Make sure to update the version for cross-referencing also in the
3333
# mkdocs.yml file when changing the version here (look for the config key
3434
# plugins.mkdocstrings.handlers.python.import)

tests_golden/integration/test_cookiecutter_generation/app/frequenz-app-test/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ dependencies = [
3131
# Make sure to update the version for cross-referencing also in the
3232
# mkdocs.yml file when changing the version here (look for the config key
3333
# plugins.mkdocstrings.handlers.python.import)
34-
"frequenz-sdk >= 1.0.0rc1300, < 1.0.0rc1400",
34+
"frequenz-sdk == 1.0.0rc1300",
3535
]
3636
dynamic = ["version"]
3737

tests_golden/integration/test_cookiecutter_generation/model/frequenz-model-test/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ classifiers = [
2828
requires-python = ">= 3.11, < 4"
2929
# TODO(cookiecutter): Remove and add more dependencies if appropriate
3030
dependencies = [
31-
"typing-extensions == 4.12.2",
31+
"typing-extensions => 4.12.2, < 5",
3232
# Make sure to update the version for cross-referencing also in the
3333
# mkdocs.yml file when changing the version here (look for the config key
3434
# plugins.mkdocstrings.handlers.python.import)

0 commit comments

Comments
 (0)