Use sets for config paths and sessions

When using lists there are time where duplicates can be introduced and
we never want to process paths or sessions more than once.

Signed-off-by: Leandro Lucarella <[email protected]>

Author: llucax

src/frequenz/repo/config/nox/config.py

@@ -61,10 +61,10 @@ class Config:
     opts: CommandsOptions = dataclasses.field(default_factory=CommandsOptions)
     """Command-line options for each command used by sessions."""
 
-    sessions: list[str] = dataclasses.field(default_factory=lambda: [])
+    sessions: set[str] = dataclasses.field(default_factory=set)
     """List of sessions to run."""
 
-    source_paths: list[str] = dataclasses.field(default_factory=lambda: [])
+    source_paths: set[str] = dataclasses.field(default_factory=set)
     """List of paths containing source files that should be analyzed by the sessions.
 
     Source paths are inspected for `__init__.py` files to look for packages.
@@ -77,7 +77,7 @@ class Config:
     checking.
     """
 
-    extra_paths: list[str] = dataclasses.field(default_factory=lambda: [])
+    extra_paths: set[str] = dataclasses.field(default_factory=set)
     """List of extra paths to be analyzed by the sessions.
 
     These are not inspected for packages, as they are passed verbatim to the
@@ -91,7 +91,7 @@ def __post_init__(self) -> None:
         """
         for path in util.discover_paths():
             if path not in self.extra_paths:
-                self.extra_paths.append(path)
+                self.extra_paths.add(path)
 
     def copy(self, /) -> Self:
         """Create a new object as a copy of self.
@@ -101,7 +101,7 @@ def copy(self, /) -> Self:
         """
         return dataclasses.replace(self)
 
-    def path_args(self, session: nox.Session, /) -> list[str]:
+    def path_args(self, session: nox.Session, /) -> set[str]:
         """Return the file paths to run the checks on.
 
         If positional arguments are present in the nox session, those are used
@@ -115,13 +115,13 @@ def path_args(self, session: nox.Session, /) -> list[str]:
             The file paths to run the checks on.
         """
         if session.posargs:
-            return session.posargs
+            return set(session.posargs)
 
-        return [
-            str(p) for p in util.existing_paths(self.source_paths + self.extra_paths)
-        ]
+        return {
+            str(p) for p in util.existing_paths(self.source_paths | self.extra_paths)
+        }
 
-    def package_args(self, session: nox.Session, /) -> list[str]:
+    def package_args(self, session: nox.Session, /) -> set[str]:
         """Return the package names to run the checks on.
 
         If positional arguments are present in the nox session, those are used
@@ -138,7 +138,7 @@ def package_args(self, session: nox.Session, /) -> list[str]:
             The package names found in the `source_paths`.
         """
         if session.posargs:
-            return session.posargs
+            return set(session.posargs)
 
         sources_package_dirs_with_roots = (
             (p, util.find_toplevel_package_dirs(p))
@@ -155,7 +155,7 @@ def package_args(self, session: nox.Session, /) -> list[str]:
             util.path_to_package(p) for p in util.existing_paths(self.extra_paths)
         )
 
-        return [*source_packages, *extra_packages]
+        return {*source_packages, *extra_packages}
 
 
 _config: Config | None = None

src/frequenz/repo/config/nox/default.py

@@ -56,24 +56,24 @@
 
 common_config = _config.Config(
     opts=common_command_options.copy(),
-    sessions=[
+    sessions={
         "formatting",
         "mypy",
         "pylint",
         "docstrings",
         "pytest_min",
         "pytest_max",
-    ],
-    source_paths=[
+    },
+    source_paths={
         "src",
-    ],
-    extra_paths=[
+    },
+    extra_paths={
         "benchmarks",
         "docs",
         "examples",
         "noxfile.py",
         "tests",
-    ],
+    },
 )
 """Default configuration for all types of repositories."""
 
@@ -90,9 +90,9 @@
     common_config,
     opts=api_command_options,
     # We don't check the sources at all because they are automatically generated.
-    source_paths=[],
+    source_paths=set(),
     # We adapt the path to the tests.
-    extra_paths=list(util.replace(common_config.extra_paths, {"tests": "pytests"})),
+    extra_paths=set(util.replace(common_config.extra_paths, {"tests": "pytests"})),
 )
 """Default configuration for APIs.