Skip to content

Commit fc96c8e

Browse files
authored
Fix release notes check for API repos (#112)
For API repos we need to check if files in the `proto/` or `py/` directories were updated, not `src/`.
2 parents 65e7c91 + c43c6ec commit fc96c8e

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

cookiecutter/{{cookiecutter.github_repo_name}}/.github/workflows/release-notes-check.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ jobs:
2525
# TODO(cookiecutter): Uncomment the following line for private repositories, otherwise remove it and remove it
2626
# token: {{'${{ secrets.github_token }}'}}
2727
file-pattern: "RELEASE_NOTES.md"
28+
{%- if cookiecutter.type == "api" %}
29+
prereq-pattern: "{proto,py}/**"
30+
{%- else %}
2831
prereq-pattern: "src/**"
32+
{%- endif %}
2933
skip-label: "cmd:skip-release-notes"
3034
failure-message: "Missing a release notes update. Please add one or apply the ${skip-label} label to the pull request"

tests_golden/integration/test_cookiecutter_generation/api/frequenz-api-test/.github/workflows/release-notes-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ jobs:
2525
# TODO(cookiecutter): Uncomment the following line for private repositories, otherwise remove it and remove it
2626
# token: ${{ secrets.github_token }}
2727
file-pattern: "RELEASE_NOTES.md"
28-
prereq-pattern: "src/**"
28+
prereq-pattern: "{proto,py}/**"
2929
skip-label: "cmd:skip-release-notes"
3030
failure-message: "Missing a release notes update. Please add one or apply the ${skip-label} label to the pull request"

0 commit comments

Comments
 (0)