Support secret to sign requests to reporting client #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Includes various naming updates that come with the new reporting client version. - Replaced deprecated `MetricSample` imports. - Updated tests to use string-based component IDs and numeric state values due to `MetricSample` now being stronly typed. Signed-off-by: cyiallou - Costas <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR supports secret-based signing for requests to the reporting client by updating naming conventions and type usages.
- Migrates MetricSample imports from the deprecated module and updates usage accordingly.
- Converts component_id values in tests from numeric to string and updates state value types from string to numeric.
- Updates API calls in the reporting module to reflect new parameter names (start_time/end_time) and method names.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_frequenz_reporting.py | Updated tests to reflect new MetricSample type conversions and value changes. |
| src/frequenz/reporting/_reporting.py | Updated MetricSample import and replaced deprecated API calls with new ones. |
| pyproject.toml | Updated dependency version for frequenz-client-reporting. |
| RELEASE_NOTES.md | Revised release notes to document the updated dependency version. |
github-actions
bot
added
part:docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricSampleimports.MetricSamplenow being stronly typed.