Delete code that has been moved #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted code that has been moved to another repo (`frequenz-lib-notebooks`). Signed-off-by: cyiallou - Costas <[email protected]>
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR removes code that has been moved to another repository (frequenz-lib-notebooks). The changes involve deleting functionality related to fetching data and extracting state durations and alert records from the reporting module.
- Removed test cases and test function for
extract_state_durationsfunctionality - Deleted state duration extraction functions and helper methods from the reporting module
- Updated release notes to document the code removal
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_frequenz_reporting.py | Removed comprehensive test cases and test function for state duration extraction |
| src/frequenz/reporting/_reporting.py | Deleted state duration extraction functions and related helper methods |
| RELEASE_NOTES.md | Updated to document the removal of moved functionality |
Comments suppressed due to low confidence (7)
src/frequenz/reporting/_reporting.py:7
- The import
from itertools import groupbyis no longer used after removing the state duration extraction functions and should be removed to avoid unused imports.
from datetime import datetime, timedelta
src/frequenz/reporting/_reporting.py:10
- The import
from frequenz.client.reporting._types import MetricSampleis no longer used after removing the state duration extraction functions and should be removed to avoid unused imports.
from frequenz.client.reporting import ReportingApiClient
tests/test_frequenz_reporting.py:4
- The import
from datetime import datetimeis no longer used after removing the state duration extraction tests and should be removed to avoid unused imports.
"""Tests for the frequenz.reporting package."""
tests/test_frequenz_reporting.py:5
- The import
from typing import Anyis no longer used after removing the state duration extraction tests and should be removed to avoid unused imports.
import pytest
tests/test_frequenz_reporting.py:7
- The import
from frequenz.client.reporting._types import MetricSampleis no longer used after removing the state duration extraction tests and should be removed to avoid unused imports.
from frequenz.reporting import delete_me
cyiallou
added
the
cmd:skip-release-notes
|
Follow up PR from #58 (comment) |
cwasicki
approved these changes
Jul 23, 2025
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jul 23, 2025
4ab7289
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted code that has been moved to another repo
(
frequenz-lib-notebooks).