Skip to content

Commit 00c48d9

Browse files
committed
Use tighter types for SetPowerResult
Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 61765a8 commit 00c48d9

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/frequenz/sdk/actor/power_distributing/_component_status.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66

77
import enum
8-
import typing
98
from abc import ABC, abstractmethod
109
from collections import abc
1110
from dataclasses import dataclass
@@ -70,10 +69,10 @@ class ComponentStatus:
7069
class SetPowerResult:
7170
"""Lists of components for which the last set power command succeeded or failed."""
7271

73-
succeeded: typing.Iterable[int]
72+
succeeded: abc.Set[int]
7473
"""Component IDs for which the last set power command succeeded."""
7574

76-
failed: typing.Iterable[int]
75+
failed: abc.Set[int]
7776
"""Component IDs for which the last set power command failed."""
7877

7978

tests/actor/test_battery_status.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ async def test_sync_blocking_interrupted_with_invalid_message(
538538
assert tracker._get_new_status_if_changed() is None
539539

540540
tracker._handle_status_set_power_result(
541-
SetPowerResult(succeeded={BATTERY_ID}, failed={})
541+
SetPowerResult(succeeded={BATTERY_ID}, failed=set())
542542
)
543543
assert tracker._get_new_status_if_changed() is None
544544

@@ -648,7 +648,7 @@ async def test_async_battery_status(self, mocker: MockerFixture) -> None:
648648
assert status.value is ComponentStatusEnum.WORKING
649649

650650
await set_power_result_sender.send(
651-
SetPowerResult(succeeded={}, failed={BATTERY_ID})
651+
SetPowerResult(succeeded=set(), failed={BATTERY_ID})
652652
)
653653
status = await asyncio.wait_for(status_receiver.receive(), timeout=0.1)
654654
assert status.value is ComponentStatusEnum.UNCERTAIN
@@ -669,7 +669,7 @@ async def test_async_battery_status(self, mocker: MockerFixture) -> None:
669669
assert status.value is ComponentStatusEnum.NOT_WORKING
670670

671671
await set_power_result_sender.send(
672-
SetPowerResult(succeeded={}, failed={BATTERY_ID})
672+
SetPowerResult(succeeded=set(), failed={BATTERY_ID})
673673
)
674674
await asyncio.sleep(0.3)
675675
assert len(status_receiver) == 0

0 commit comments

Comments
 (0)