Add more unit tests for gaps

Signed-off-by: cwasicki <[email protected]>

Author: cwasicki

tests/timeseries/test_ringbuffer.py

@@ -192,6 +192,67 @@ def test_timestamp_ringbuffer_missing_parameter(
     assert len(buffer.gaps) == 1
 
 
+def dt(i: int) -> datetime:  # pylint: disable=invalid-name
+    """Create datetime objects from indices.
+
+    Args:
+        i: Index to create datetime from.
+
+    Returns:
+        Datetime object.
+    """
+    return datetime.fromtimestamp(i, tz=timezone.utc)
+
+
+def test_gaps() -> None:
+    """Test gap treatment in ordered ring buffer."""
+    buffer = OrderedRingBuffer([0.0] * 5, ONE_SECOND)
+    assert len(buffer) == 0
+    assert len(buffer.gaps) == 0
+
+    buffer.update(Sample(dt(0), Quantity(0)))
+    assert len(buffer) == 1
+    assert len(buffer.gaps) == 1
+
+    buffer.update(Sample(dt(6), Quantity(0)))
+    assert len(buffer) == 1
+    assert len(buffer.gaps) == 1
+
+    buffer.update(Sample(dt(2), Quantity(2)))
+    buffer.update(Sample(dt(3), Quantity(3)))
+    buffer.update(Sample(dt(4), Quantity(4)))
+    assert len(buffer) == 4
+    assert len(buffer.gaps) == 1
+
+    buffer.update(Sample(dt(3), None))
+    assert len(buffer) == 3
+    assert len(buffer.gaps) == 2
+
+    buffer.update(Sample(dt(3), Quantity(np.nan)))
+    assert len(buffer) == 4  # should be 3
+    assert len(buffer.gaps) == 1  # should be 2
+
+    buffer.update(Sample(dt(2), Quantity(np.nan)))
+    assert len(buffer) == 4  # should be 2
+    assert len(buffer.gaps) == 1  # should be 2
+
+    buffer.update(Sample(dt(3), Quantity(3)))
+    assert len(buffer) == 4  # should be 3
+    assert len(buffer.gaps) == 1  # should be 2
+
+    buffer.update(Sample(dt(2), Quantity(2)))
+    assert len(buffer) == 4
+    assert len(buffer.gaps) == 1
+
+    buffer.update(Sample(dt(5), Quantity(5)))
+    assert len(buffer) == 5
+    assert len(buffer.gaps) == 0
+
+    buffer.update(Sample(dt(99), None))
+    assert len(buffer) == 4  # bug: should be 0 (whole range gap)
+    assert len(buffer.gaps) == 1
+
+
 @pytest.mark.parametrize(
     "buffer",
     [