Fix minimum requirements test (#163)

The test using `minimum-requirements-ci.txt` was broken. The
`minimum-requirements-ci.txt` file was not being used in isolation
because initially`all the dependencies were installed from the
`pyproject.toml` file. So dependencies that were present in
`pyproject.toml` but not in `minimum-requirements-ci.txt` won't have
triggered an error when testing the minimum requirements.

This patch generated a minimum dependencies list out of the dependencies
defined in `pyproject.toml` file and uses it instead of
`minimum-requirements-ci.txt` to avoid having differences between two
different sources of minimum requirements/dependencies.

Fixes #42

Author: daniel-zullo-frequenz

.github/workflows/ci.yaml

@@ -35,7 +35,7 @@ jobs:
       - name: Install required Python packages
         run: |
           python -m pip install --upgrade pip
-          python -m pip install nox
+          python -m pip install nox toml
 
       - name: run nox
         run: nox -e ci_checks_max pytest_min

minimum-requirements-ci.txt

@@ -10,6 +10,36 @@
 from typing import List
 
 import nox
+import toml
+
+
+def min_dependencies() -> List[str]:
+    """Extract the minimum dependencies from pyproject.toml.
+
+    Raises:
+        Exception: If minimun dependencies are not properly
+            set in pyproject.toml.
+
+    Returns:
+        the minimun dependencies defined in pyproject.toml.
+
+    """
+    with open("pyproject.toml", "r", encoding="utf-8") as toml_file:
+        data = toml.load(toml_file)
+
+    dependencies = data.get("project", {}).get("dependencies", {})
+    if not dependencies:
+        raise Exception(f"No dependencies found in file: {toml_file.name}")
+
+    min_deps: List[str] = []
+    for dep in dependencies:
+        min_dep = dep.split(",")[0]
+        if any(op in min_dep for op in (">=", "==")):
+            min_deps.append(min_dep.replace(">=", "=="))
+        else:
+            raise Exception(f"Minimum requirement is not set: {dep}")
+    return min_deps
+
 
 FMT_DEPS = ["black", "isort"]
 DOCSTRING_DEPS = ["pydocstyle", "darglint"]
@@ -22,6 +52,7 @@
     "async-solipsism",
 ]
 MYPY_DEPS = ["mypy", "pandas-stubs", "grpc-stubs"]
+MIN_DEPS = min_dependencies()
 
 
 def _source_file_paths(session: nox.Session) -> List[str]:
@@ -220,7 +251,7 @@ def pytest_min(session: nox.Session, install_deps: bool = True) -> None:
     if install_deps:
         # install the package itself as editable, so that it is possible to do
         # fast local tests with `nox -R -e pytest_min`.
-        session.install("-e", ".", *PYTEST_DEPS, "-r", "minimum-requirements-ci.txt")
+        session.install("-e", ".", *PYTEST_DEPS, *MIN_DEPS)
 
     _pytest_impl(session, "min")
 

noxfile.py

@@ -32,7 +32,7 @@ dependencies = [
     "grpcio-tools >= 1.51.1, < 2",
     "networkx >= 2.8, < 3",
     "pandas >= 1.5.2, < 2",
-    "protobuf >= 4.21, < 5",
+    "protobuf >= 4.21.6, < 5",
     "pyarrow >= 10.0.1, < 11",
     "pydantic >= 1.9",
     "sympy >= 1.10.1, < 2",