Remove the initial wait time in the power distributor

The power distributor is no longer controlled directly by the users,
but instead gets requests only from the power manager.  So if will not
receive requests until there's data.

But if it receives requests when there's no data, it will return an
`Error` response, saying there's no data.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

benchmarks/power_distribution/power_distributor.py

@@ -120,7 +120,6 @@ async def run_test(  # pylint: disable=too-many-locals
         requests_receiver=power_request_channel.new_receiver(),
         results_sender=power_result_channel.new_sender(),
         component_pool_status_sender=battery_status_channel.new_sender(),
-        wait_for_data_sec=2.0,
     ):
         tasks: list[Coroutine[Any, Any, list[Result]]] = []
         tasks.append(send_requests(batteries, num_requests))

src/frequenz/sdk/actor/power_distributing/power_distributing.py

@@ -12,8 +12,6 @@
 """
 
 
-import asyncio
-
 from frequenz.channels import Receiver, Sender
 from frequenz.client.microgrid import ComponentCategory, ComponentType, InverterType
 
@@ -60,7 +58,6 @@ def __init__(  # pylint: disable=too-many-arguments
         requests_receiver: Receiver[Request],
         results_sender: Sender[Result],
         component_pool_status_sender: Sender[ComponentPoolStatus],
-        wait_for_data_sec: float,
         *,
         component_category: ComponentCategory,
         component_type: ComponentType | None = None,
@@ -74,8 +71,6 @@ def __init__(  # pylint: disable=too-many-arguments
             results_sender: Sender for sending results to the power manager.
             component_pool_status_sender: Channel for sending information about which
                 components are expected to be working.
-            wait_for_data_sec: How long actor should wait before processing first
-                request. It is a time needed to collect first components data.
             component_category: The category of the components that this actor is
                 responsible for.
             component_type: The type of the component of the given category that this
@@ -96,7 +91,6 @@ def __init__(  # pylint: disable=too-many-arguments
         self._component_type = component_type
         self._requests_receiver = requests_receiver
         self._result_sender = results_sender
-        self._wait_for_data_sec = wait_for_data_sec
 
         self._component_manager: ComponentManager
         if component_category == ComponentCategory.BATTERY:
@@ -130,9 +124,6 @@ async def _run(self) -> None:  # pylint: disable=too-many-locals
         """
         await self._component_manager.start()
 
-        # Wait few seconds to get data from the channels created above.
-        await asyncio.sleep(self._wait_for_data_sec)
-
         async for request in self._requests_receiver:
             await self._component_manager.distribute_power(request)
 

src/frequenz/sdk/microgrid/_power_wrapper.py

@@ -30,8 +30,6 @@
 
 _logger = logging.getLogger(__name__)
 
-_POWER_DISTRIBUTING_ACTOR_WAIT_FOR_DATA_SEC = 2.0
-
 
 class PowerWrapper:
     """Wrapper around the power managing and power distributing actors."""
@@ -80,7 +78,6 @@ def __init__(
 
         self._power_distributing_actor: PowerDistributingActor | None = None
         self._power_managing_actor: _power_managing.PowerManagingActor | None = None
-        self._pd_wait_for_data_sec: float = _POWER_DISTRIBUTING_ACTOR_WAIT_FOR_DATA_SEC
 
     def _start_power_managing_actor(self) -> None:
         """Start the power managing actor if it is not already running."""
@@ -151,7 +148,6 @@ def _start_power_distributing_actor(self) -> None:
             requests_receiver=self._power_distribution_requests_channel.new_receiver(),
             results_sender=self._power_distribution_results_channel.new_sender(),
             component_pool_status_sender=self.status_channel.new_sender(),
-            wait_for_data_sec=self._pd_wait_for_data_sec,
         )
         self._power_distributing_actor.start()