Skip to content

Commit 264d16f

Browse files
committed
Translate discharge power to passive-sign convention
Earlier this had a bug and was proposing a charging power instead. Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 364d594 commit 264d16f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/frequenz/sdk/timeseries/battery_pool/_battery_pool.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,10 @@ async def propose_discharge(
215215
Raises:
216216
ValueError: If the given power is negative.
217217
"""
218-
if power and power < Power.zero():
219-
raise ValueError("Discharge power must be positive.")
218+
if power:
219+
if power < Power.zero():
220+
raise ValueError("Discharge power must be positive.")
221+
power = -power
220222
await self._battery_pool._power_manager_requests_sender.send(
221223
_power_managing.Proposal(
222224
source_id=self._source_id,

0 commit comments

Comments
 (0)