Define how long PowerDistributor should wait for data as a constant

Also remove the default value from the PowerDistributor constructor,
which allows the value to be mocked/overridden before a
PowerDistributor instance is created.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

benchmarks/power_distribution/power_distributor.py

@@ -119,6 +119,7 @@ async def run_test(  # pylint: disable=too-many-locals
         requests_receiver=power_request_channel.new_receiver(),
         results_sender=power_result_channel.new_sender(),
         component_pool_status_sender=battery_status_channel.new_sender(),
+        wait_for_data_sec=2.0,
     ):
         tasks: list[Coroutine[Any, Any, list[Result]]] = []
         tasks.append(send_requests(batteries, num_requests))

src/frequenz/sdk/actor/power_distributing/power_distributing.py

@@ -56,7 +56,7 @@ def __init__(  # pylint: disable=too-many-arguments
         requests_receiver: Receiver[Request],
         results_sender: Sender[Result],
         component_pool_status_sender: Sender[ComponentPoolStatus],
-        wait_for_data_sec: float = 2,
+        wait_for_data_sec: float,
         *,
         name: str | None = None,
     ) -> None:

src/frequenz/sdk/microgrid/_power_wrapper.py

@@ -30,6 +30,8 @@
 
 _logger = logging.getLogger(__name__)
 
+_POWER_DISTRIBUTING_ACTOR_WAIT_FOR_DATA_SEC = 2.0
+
 
 class PowerWrapper:
     """Wrapper around the power managing and power distributing actors."""
@@ -66,6 +68,7 @@ def __init__(
 
         self._power_distributing_actor: PowerDistributingActor | None = None
         self._power_managing_actor: _power_managing.PowerManagingActor | None = None
+        self._pd_wait_for_data_sec: float = _POWER_DISTRIBUTING_ACTOR_WAIT_FOR_DATA_SEC
 
     def _start_power_managing_actor(self) -> None:
         """Start the power managing actor if it is not already running."""
@@ -134,6 +137,7 @@ def _start_power_distributing_actor(self) -> None:
             requests_receiver=self._power_distribution_requests_channel.new_receiver(),
             results_sender=self._power_distribution_results_channel.new_sender(),
             component_pool_status_sender=self.status_channel.new_sender(),
+            wait_for_data_sec=self._pd_wait_for_data_sec,
         )
         self._power_distributing_actor.start()
 

tests/actor/power_distributing/test_power_distributing.py

@@ -111,6 +111,7 @@ async def test_constructor_with_grid_meter(self, mocker: MockerFixture) -> None:
                 requests_receiver=requests_channel.new_receiver(),
                 results_sender=results_channel.new_sender(),
                 component_pool_status_sender=battery_status_channel.new_sender(),
+                wait_for_data_sec=0.0,
             ) as distributor:
                 assert isinstance(distributor._component_manager, BatteryManager)
                 assert distributor._component_manager._bat_invs_map == {
@@ -141,6 +142,7 @@ async def test_constructor_without_grid_meter(self, mocker: MockerFixture) -> No
                 requests_receiver=requests_channel.new_receiver(),
                 results_sender=results_channel.new_sender(),
                 component_pool_status_sender=battery_status_channel.new_sender(),
+                wait_for_data_sec=0.0,
             ) as distributor:
                 assert isinstance(distributor._component_manager, BatteryManager)
                 assert distributor._component_manager._bat_invs_map == {