Skip to content

Commit 4ecdc79

Browse files
committed
Make all *Pool constructors take only keyword arguments
There's going to be more parameters soon, so this would be make it easier to read. Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 79225f5 commit 4ecdc79

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

src/frequenz/sdk/microgrid/_data_pipeline.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,9 @@ def ev_charger_pool(
261261
)
262262
)
263263
return EVChargerPool(
264-
self._ev_charger_pool_reference_stores[ref_store_key], name, priority
264+
pool_ref_store=self._ev_charger_pool_reference_stores[ref_store_key],
265+
name=name,
266+
priority=priority,
265267
)
266268

267269
def pv_pool(
@@ -328,7 +330,11 @@ def pv_pool(
328330
component_ids=component_ids,
329331
)
330332

331-
return PVPool(self._pv_pool_reference_stores[ref_store_key], name, priority)
333+
return PVPool(
334+
pool_ref_store=self._pv_pool_reference_stores[ref_store_key],
335+
name=name,
336+
priority=priority,
337+
)
332338

333339
def battery_pool(
334340
self,
@@ -400,7 +406,9 @@ def battery_pool(
400406
)
401407

402408
return BatteryPool(
403-
self._battery_pool_reference_stores[ref_store_key], name, priority
409+
pool_ref_store=self._battery_pool_reference_stores[ref_store_key],
410+
name=name,
411+
priority=priority,
404412
)
405413

406414
def _data_sourcing_request_sender(self) -> Sender[ComponentMetricRequest]:

src/frequenz/sdk/timeseries/battery_pool/_battery_pool.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ class BatteryPool:
5555

5656
def __init__(
5757
self,
58+
*,
5859
pool_ref_store: BatteryPoolReferenceStore,
5960
name: str | None,
6061
priority: int,

src/frequenz/sdk/timeseries/ev_charger_pool/_ev_charger_pool.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class EVChargerPool:
4141

4242
def __init__( # pylint: disable=too-many-arguments
4343
self,
44+
*,
4445
pool_ref_store: EVChargerPoolReferenceStore,
4546
name: str | None,
4647
priority: int,

src/frequenz/sdk/timeseries/pv_pool/_pv_pool.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class PVPool:
3434

3535
def __init__( # pylint: disable=too-many-arguments
3636
self,
37+
*,
3738
pool_ref_store: PVPoolReferenceStore,
3839
name: str | None,
3940
priority: int,

0 commit comments

Comments
 (0)