Update float("NaN") to math.nan

Signed-off-by: Jack <[email protected]>

Author: jack-herrmann

src/frequenz/sdk/timeseries/_formula_engine/_formula_steps.py

@@ -5,6 +5,7 @@
 
 from __future__ import annotations
 
+import math
 from abc import ABC, abstractmethod
 from typing import Generic, List, Optional
 
@@ -326,6 +327,6 @@ def apply(self, eval_stack: List[float]) -> None:
             if self._nones_are_zeros:
                 eval_stack.append(0.0)
             else:
-                eval_stack.append(float("NaN"))
+                eval_stack.append(math.nan)
         else:
             eval_stack.append(next_value.base_value)

tests/actor/test_battery_status.py

@@ -3,6 +3,7 @@
 """Tests for BatteryStatusTracker."""
 
 import asyncio
+import math
 from dataclasses import dataclass
 from datetime import datetime, timedelta, timezone
 from typing import Generic, Iterable, List, Optional, Set, Tuple, TypeVar
@@ -358,7 +359,7 @@ async def test_sync_update_status_with_messages(
         assert tracker._update_status(select) is Status.WORKING  # type: ignore[arg-type]
 
         select = FakeSelect(
-            battery=battery_data(component_id=BATTERY_ID, capacity=float("NaN"))
+            battery=battery_data(component_id=BATTERY_ID, capacity=math.nan)
         )
         assert tracker._update_status(select) is Status.NOT_WORKING  # type: ignore[arg-type]
 

tests/actor/test_power_distributing.py

@@ -6,6 +6,7 @@
 from __future__ import annotations
 
 import asyncio
+import math
 import re
 from typing import TypeVar
 from unittest.mock import AsyncMock, MagicMock
@@ -190,7 +191,7 @@ async def test_battery_soc_nan(self, mocker: MockerFixture) -> None:
         await mock_microgrid.send(
             battery_msg(
                 106,
-                soc=Metric(float("NaN"), Bound(20, 80)),
+                soc=Metric(math.nan, Bound(20, 80)),
                 capacity=Metric(98000),
                 power=Bound(-1000, 1000),
             )
@@ -254,7 +255,7 @@ async def test_battery_capacity_nan(self, mocker: MockerFixture) -> None:
             battery_msg(
                 106,
                 soc=Metric(40, Bound(20, 80)),
-                capacity=Metric(float("NaN")),
+                capacity=Metric(math.nan),
                 power=Bound(-1000, 1000),
             )
         )
@@ -310,15 +311,15 @@ async def test_battery_power_bounds_nan(self, mocker: MockerFixture) -> None:
         await mock_microgrid.send(
             inverter_msg(
                 205,
-                power=Bound(float("NaN"), float("NaN")),
+                power=Bound(math.nan, math.nan),
             )
         )
 
         # Battery 106 should not work because both battery and inverter sends NaN
         await mock_microgrid.send(
             inverter_msg(
                 105,
-                power=Bound(-1000, float("NaN")),
+                power=Bound(-1000, math.nan),
             )
         )
 
@@ -327,7 +328,7 @@ async def test_battery_power_bounds_nan(self, mocker: MockerFixture) -> None:
                 106,
                 soc=Metric(40, Bound(20, 80)),
                 capacity=Metric(float(98000)),
-                power=Bound(float("NaN"), float("NaN")),
+                power=Bound(math.nan, math.nan),
             )
         )
 
@@ -760,14 +761,14 @@ async def test_force_request_battery_nan_value_non_cached(
         batteries_data = (
             battery_msg(
                 106,
-                soc=Metric(float("NaN"), Bound(20, 80)),
-                capacity=Metric(float("NaN")),
+                soc=Metric(math.nan, Bound(20, 80)),
+                capacity=Metric(math.nan),
                 power=Bound(-1000, 1000),
             ),
             battery_msg(
                 206,
                 soc=Metric(40, Bound(20, 80)),
-                capacity=Metric(float("NaN")),
+                capacity=Metric(math.nan),
                 power=Bound(-1000, 1000),
             ),
         )
@@ -846,21 +847,21 @@ async def test_result() -> None:
         batteries_data = (
             battery_msg(
                 106,
-                soc=Metric(float("NaN"), Bound(20, 80)),
+                soc=Metric(math.nan, Bound(20, 80)),
                 capacity=Metric(98000),
                 power=Bound(-1000, 1000),
             ),
             battery_msg(
                 206,
                 soc=Metric(40, Bound(20, 80)),
-                capacity=Metric(float("NaN")),
+                capacity=Metric(math.nan),
                 power=Bound(-1000, 1000),
             ),
             battery_msg(
                 306,
                 soc=Metric(40, Bound(20, 80)),
                 capacity=Metric(float(98000)),
-                power=Bound(float("NaN"), float("NaN")),
+                power=Bound(math.nan, math.nan),
             ),
         )
 

tests/power/test_distribution_algorithm.py

@@ -3,6 +3,7 @@
 
 # pylint: disable=too-many-lines
 """Tests for distribution algorithm."""
+import math
 from dataclasses import dataclass
 from datetime import datetime, timezone
 from typing import Dict, List, Optional
@@ -62,10 +63,10 @@ def battery_msg(  # pylint: disable=too-many-arguments
     """
     return BatteryDataWrapper(
         component_id=component_id,
-        capacity=capacity.now if capacity.now is not None else float("NaN"),
-        soc=soc.now if soc.now is not None else float("NaN"),
-        soc_lower_bound=soc.bound.lower if soc.bound is not None else float("NaN"),
-        soc_upper_bound=soc.bound.upper if soc.bound is not None else float("NaN"),
+        capacity=capacity.now if capacity.now is not None else math.nan,
+        soc=soc.now if soc.now is not None else math.nan,
+        soc_lower_bound=soc.bound.lower if soc.bound is not None else math.nan,
+        soc_upper_bound=soc.bound.upper if soc.bound is not None else math.nan,
         power_lower_bound=power.lower,
         power_upper_bound=power.upper,
         timestamp=timestamp,

tests/timeseries/_battery_pool/test_battery_pool.py

@@ -7,6 +7,7 @@
 import asyncio
 import dataclasses
 import logging
+import math
 from dataclasses import dataclass, is_dataclass, replace
 from datetime import datetime, timedelta, timezone
 from typing import Any, AsyncIterator, Generic, Iterator, TypeVar
@@ -565,7 +566,7 @@ async def run_capacity_test(setup_args: SetupArgs) -> None:
         ),
         Scenario(
             batteries_in_pool[1],
-            {"soc_upper_bound": float("NaN")},
+            {"soc_upper_bound": math.nan},
             Sample(
                 now,
                 Energy.from_watt_hours(
@@ -595,7 +596,7 @@ async def run_capacity_test(setup_args: SetupArgs) -> None:
         ),
         Scenario(
             batteries_in_pool[1],
-            {"capacity": float("NaN")},
+            {"capacity": math.nan},
             Sample(
                 now,
                 Energy.from_watt_hours(
@@ -709,13 +710,13 @@ async def run_soc_test(setup_args: SetupArgs) -> None:
         # If NaN, then not include that battery in the metric.
         Scenario(
             batteries_in_pool[0],
-            {"soc_upper_bound": float("NaN")},
+            {"soc_upper_bound": math.nan},
             Sample(now, Percentage.from_percent(10.0)),
         ),
         # All batteries are sending NaN, can't calculate SoC so we should send None
         Scenario(
             batteries_in_pool[1],
-            {"soc": float("NaN")},
+            {"soc": math.nan},
             None,
         ),
         Scenario(
@@ -866,44 +867,44 @@ async def run_power_bounds_test(  # pylint: disable=too-many-locals
         # Setting upper bound to NaN should not influence lower bound
         Scenario(
             batteries_in_pool[0],
-            {"power_lower_bound": -50, "power_upper_bound": float("NaN")},
+            {"power_lower_bound": -50, "power_upper_bound": math.nan},
             PowerMetrics(now, Bound(-60, 0), Bound(0, 9200)),
         ),
         Scenario(
             bat_inv_map[batteries_in_pool[0]],
             {
-                "active_power_lower_bound": float("NaN"),
-                "active_power_upper_bound": float("NaN"),
+                "active_power_lower_bound": math.nan,
+                "active_power_upper_bound": math.nan,
             },
             PowerMetrics(now, Bound(-60, 0), Bound(0, 200)),
         ),
         Scenario(
             batteries_in_pool[0],
-            {"power_lower_bound": float("NaN")},
+            {"power_lower_bound": math.nan},
             PowerMetrics(now, Bound(-10, 0), Bound(0, 200)),
         ),
         Scenario(
             batteries_in_pool[1],
             {
                 "power_lower_bound": -100,
-                "power_upper_bound": float("NaN"),
+                "power_upper_bound": math.nan,
             },
             PowerMetrics(now, Bound(-100, 0), Bound(0, 6000)),
         ),
         Scenario(
             bat_inv_map[batteries_in_pool[1]],
             {
-                "active_power_lower_bound": float("NaN"),
-                "active_power_upper_bound": float("NaN"),
+                "active_power_lower_bound": math.nan,
+                "active_power_upper_bound": math.nan,
             },
             PowerMetrics(now, Bound(-100, 0), Bound(0, 0)),
         ),
         # All components are sending NaN, can't calculate bounds
         Scenario(
             batteries_in_pool[1],
             {
-                "power_lower_bound": float("NaN"),
-                "power_upper_bound": float("NaN"),
+                "power_lower_bound": math.nan,
+                "power_upper_bound": math.nan,
             },
             None,
         ),

tests/utils/component_data_wrapper.py

@@ -12,6 +12,7 @@
 """
 from __future__ import annotations
 
+import math
 from dataclasses import dataclass, field, replace
 from datetime import datetime
 from typing import Tuple
@@ -33,13 +34,13 @@
 class BatteryDataWrapper(BatteryData):
     """Wrapper for the BatteryData with default arguments."""
 
-    soc: float = float("NaN")
-    soc_lower_bound: float = float("NaN")
-    soc_upper_bound: float = float("NaN")
-    capacity: float = float("NaN")
-    power_lower_bound: float = float("NaN")
-    power_upper_bound: float = float("NaN")
-    temperature_max: float = float("NaN")
+    soc: float = math.nan
+    soc_lower_bound: float = math.nan
+    soc_upper_bound: float = math.nan
+    capacity: float = math.nan
+    power_lower_bound: float = math.nan
+    power_upper_bound: float = math.nan
+    temperature_max: float = math.nan
     _relay_state: battery_pb.RelayState.ValueType = (
         battery_pb.RelayState.RELAY_STATE_UNSPECIFIED
     )
@@ -67,9 +68,9 @@ def copy_with_new_timestamp(self, new_timestamp: datetime) -> BatteryDataWrapper
 class InverterDataWrapper(InverterData):
     """Wrapper for the InverterData with default arguments."""
 
-    active_power: float = float("NaN")
-    active_power_lower_bound: float = float("NaN")
-    active_power_upper_bound: float = float("NaN")
+    active_power: float = math.nan
+    active_power_lower_bound: float = math.nan
+    active_power_upper_bound: float = math.nan
     _component_state: inverter_pb.ComponentState.ValueType = (
         inverter_pb.ComponentState.COMPONENT_STATE_UNSPECIFIED
     )
@@ -94,12 +95,12 @@ def copy_with_new_timestamp(self, new_timestamp: datetime) -> InverterDataWrappe
 class EvChargerDataWrapper(EVChargerData):
     """Wrapper for the EvChargerData with default arguments."""
 
-    active_power: float = float("NaN")
+    active_power: float = math.nan
     current_per_phase: Tuple[float, float, float] = field(
-        default_factory=lambda: (float("NaN"), float("NaN"), float("NaN"))
+        default_factory=lambda: (math.nan, math.nan, math.nan)
     )
     voltage_per_phase: Tuple[float, float, float] = field(
-        default_factory=lambda: (float("NaN"), float("NaN"), float("NaN"))
+        default_factory=lambda: (math.nan, math.nan, math.nan)
     )
     cable_state: EVChargerCableState = EVChargerCableState.UNSPECIFIED
     component_state: EVChargerComponentState = EVChargerComponentState.UNSPECIFIED
@@ -123,14 +124,14 @@ def copy_with_new_timestamp(self, new_timestamp: datetime) -> EvChargerDataWrapp
 class MeterDataWrapper(MeterData):
     """Wrapper for the MeterData with default arguments."""
 
-    active_power: float = float("NaN")
+    active_power: float = math.nan
     current_per_phase: Tuple[float, float, float] = field(
-        default_factory=lambda: (float("NaN"), float("NaN"), float("NaN"))
+        default_factory=lambda: (math.nan, math.nan, math.nan)
     )
     voltage_per_phase: Tuple[float, float, float] = field(
-        default_factory=lambda: (float("NaN"), float("NaN"), float("NaN"))
+        default_factory=lambda: (math.nan, math.nan, math.nan)
     )
-    frequency: float = float("NaN")
+    frequency: float = math.nan
 
     def copy_with_new_timestamp(self, new_timestamp: datetime) -> MeterDataWrapper:
         """Copy the component data but insert new timestamp.