Use solipsism, time-machine in *Pool tests (#1013)

This makes the tests less flaky.

Closes #901

Author: shsms

tests/timeseries/_battery_pool/test_battery_pool_control_methods.py

@@ -9,6 +9,7 @@
 from datetime import datetime, timedelta, timezone
 from unittest.mock import AsyncMock, MagicMock
 
+import async_solipsism
 import pytest
 from frequenz.channels import LatestValueCache, Sender
 from pytest_mock import MockerFixture
@@ -27,6 +28,12 @@
 from ..mock_microgrid import MockMicrogrid
 
 
+@pytest.fixture
+def event_loop_policy() -> async_solipsism.EventLoopPolicy:
+    """Event loop policy."""
+    return async_solipsism.EventLoopPolicy()
+
+
 @dataclasses.dataclass(frozen=True)
 class Mocks:
     """Mocks for the tests."""
@@ -89,11 +96,6 @@ async def _patch_battery_pool_status(
         If `battery_ids` is not None, the mock will always return `battery_ids`.
         Otherwise, it will return the requested batteries.
         """
-        mocker.patch.object(
-            timeseries.battery_pool._methods,  # pylint: disable=protected-access
-            "WAIT_FOR_COMPONENT_DATA_SEC",
-            0.1,
-        )
         if battery_ids:
             mock = MagicMock(spec=ComponentPoolStatusTracker)
             mock.get_working_components.return_value = battery_ids

tests/timeseries/_ev_charger_pool/test_ev_charger_pool_control_methods.py

@@ -8,21 +8,16 @@
 from datetime import datetime, timedelta, timezone
 from unittest.mock import AsyncMock, MagicMock
 
+import async_solipsism
 import pytest
+import time_machine
 from frequenz.channels import Receiver
 from frequenz.client.microgrid import EVChargerCableState, EVChargerComponentState
 from pytest_mock import MockerFixture
 
 from frequenz.sdk import microgrid
 from frequenz.sdk.actor import ResamplerConfig, power_distributing
-from frequenz.sdk.actor.power_distributing import (
-    ComponentPoolStatus,
-    PowerDistributingActor,
-)
-from frequenz.sdk.actor.power_distributing._component_managers import EVChargerManager
-from frequenz.sdk.actor.power_distributing._component_managers._ev_charger_manager._config import (
-    EVDistributionConfig,
-)
+from frequenz.sdk.actor.power_distributing import ComponentPoolStatus
 from frequenz.sdk.actor.power_distributing._component_pool_status_tracker import (
     ComponentPoolStatusTracker,
 )
@@ -38,6 +33,12 @@
 # pylint: disable=protected-access
 
 
+@pytest.fixture
+def event_loop_policy() -> async_solipsism.EventLoopPolicy:
+    """Event loop policy."""
+    return async_solipsism.EventLoopPolicy()
+
+
 @pytest.fixture
 async def mocks(mocker: MockerFixture) -> typing.AsyncIterator[_Mocks]:
     """Create the mocks."""
@@ -100,24 +101,6 @@ async def _patch_power_distributing_actor(
         self,
         mocker: MockerFixture,
     ) -> None:
-        dp = typing.cast(_DataPipeline, microgrid._data_pipeline._DATA_PIPELINE)
-        pda = typing.cast(
-            PowerDistributingActor, dp._ev_power_wrapper._power_distributing_actor
-        )
-        cm = typing.cast(
-            EVChargerManager,
-            pda._component_manager,
-        )
-        mocker.patch(
-            "frequenz.sdk.microgrid._data_pipeline._DATA_PIPELINE._ev_power_wrapper"
-            "._power_distributing_actor._component_manager._config",
-            EVDistributionConfig(
-                component_ids=cm._config.component_ids,
-                initial_current=cm._config.initial_current,
-                min_current=cm._config.min_current,
-                increase_power_interval=timedelta(seconds=0.12),
-            ),
-        )
         mocker.patch(
             "frequenz.sdk.microgrid._data_pipeline._DATA_PIPELINE._ev_power_wrapper"
             "._power_distributing_actor._component_manager._voltage_cache.get",
@@ -202,10 +185,12 @@ async def test_setting_power(
         mocker: MockerFixture,
     ) -> None:
         """Test setting power."""
+        traveller = time_machine.travel(datetime(2012, 12, 12))
+        mock_time = traveller.start()
+
         set_power = typing.cast(
             AsyncMock, microgrid.connection_manager.get().api_client.set_power
         )
-
         await self._init_ev_chargers(mocks)
         ev_charger_pool = microgrid.new_ev_charger_pool(priority=5)
         await self._patch_ev_pool_status(mocks, mocker)
@@ -228,6 +213,7 @@ async def test_setting_power(
         self._assert_report(
             await bounds_rx.receive(), power=40000.0, lower=0.0, upper=44160.0
         )
+        mock_time.shift(timedelta(seconds=60))
         await asyncio.sleep(0.15)
 
         # Components are set initial power
@@ -237,6 +223,7 @@ async def test_setting_power(
         # All available power is allocated. 3 chargers are set to 11040.0
         # and the last one is set to 6880.0
         set_power.reset_mock()
+        mock_time.shift(timedelta(seconds=60))
         await asyncio.sleep(0.15)
         assert set_power.call_count == 4
 
@@ -255,3 +242,5 @@ async def test_setting_power(
         stopped_evs = [x.args for x in set_power.call_args_list if x.args[1] == 0.0]
         assert 1 == len(stopped_evs)
         assert stopped_evs[0][0] in [evc[0] for evc in evs_11040]
+
+        traveller.stop()

tests/timeseries/_pv_pool/test_pv_pool_control_methods.py

@@ -8,6 +8,7 @@
 from datetime import datetime, timedelta, timezone
 from unittest.mock import AsyncMock
 
+import async_solipsism
 import pytest
 from frequenz.channels import Receiver
 from frequenz.client.microgrid import InverterComponentState
@@ -25,6 +26,12 @@
 from ..mock_microgrid import MockMicrogrid
 
 
+@pytest.fixture
+def event_loop_policy() -> async_solipsism.EventLoopPolicy:
+    """Event loop policy."""
+    return async_solipsism.EventLoopPolicy()
+
+
 @pytest.fixture
 async def mocks(mocker: MockerFixture) -> typing.AsyncIterator[_Mocks]:
     """Create the mocks."""