Skip to content

Commit 5b4cb32

Browse files
committed
Rename reference-store key variable names to be more accurate
Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 8a3a38a commit 5b4cb32

File tree

1 file changed

+43
-37
lines changed

1 file changed

+43
-37
lines changed

src/frequenz/sdk/microgrid/_data_pipeline.py

Lines changed: 43 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -195,27 +195,29 @@ def ev_charger_pool(
195195
self._ev_power_wrapper.start()
196196

197197
# We use frozenset to make a hashable key from the input set.
198-
key: frozenset[int] = frozenset()
198+
ref_store_key: frozenset[int] = frozenset()
199199
if ev_charger_ids is not None:
200-
key = frozenset(ev_charger_ids)
201-
202-
if key not in self._ev_charger_pool_reference_stores:
203-
self._ev_charger_pool_reference_stores[key] = EVChargerPoolReferenceStore(
204-
channel_registry=self._channel_registry,
205-
resampler_subscription_sender=self._resampling_request_sender(),
206-
status_receiver=self._ev_power_wrapper.status_channel.new_receiver(
207-
limit=1
208-
),
209-
power_manager_requests_sender=(
210-
self._ev_power_wrapper.proposal_channel.new_sender()
211-
),
212-
power_manager_bounds_subs_sender=(
213-
self._ev_power_wrapper.bounds_subscription_channel.new_sender()
214-
),
215-
component_ids=ev_charger_ids,
200+
ref_store_key = frozenset(ev_charger_ids)
201+
202+
if ref_store_key not in self._ev_charger_pool_reference_stores:
203+
self._ev_charger_pool_reference_stores[ref_store_key] = (
204+
EVChargerPoolReferenceStore(
205+
channel_registry=self._channel_registry,
206+
resampler_subscription_sender=self._resampling_request_sender(),
207+
status_receiver=self._ev_power_wrapper.status_channel.new_receiver(
208+
limit=1
209+
),
210+
power_manager_requests_sender=(
211+
self._ev_power_wrapper.proposal_channel.new_sender()
212+
),
213+
power_manager_bounds_subs_sender=(
214+
self._ev_power_wrapper.bounds_subscription_channel.new_sender()
215+
),
216+
component_ids=ev_charger_ids,
217+
)
216218
)
217219
return EVChargerPool(
218-
self._ev_charger_pool_reference_stores[key], name, priority
220+
self._ev_charger_pool_reference_stores[ref_store_key], name, priority
219221
)
220222

221223
def grid(self) -> Grid:
@@ -259,28 +261,32 @@ def battery_pool(
259261
self._battery_power_wrapper.start()
260262

261263
# We use frozenset to make a hashable key from the input set.
262-
key: frozenset[int] = frozenset()
264+
ref_store_key: frozenset[int] = frozenset()
263265
if battery_ids is not None:
264-
key = frozenset(battery_ids)
265-
266-
if key not in self._battery_pool_reference_stores:
267-
self._battery_pool_reference_stores[key] = BatteryPoolReferenceStore(
268-
channel_registry=self._channel_registry,
269-
resampler_subscription_sender=self._resampling_request_sender(),
270-
batteries_status_receiver=(
271-
self._battery_power_wrapper.status_channel.new_receiver(limit=1)
272-
),
273-
power_manager_requests_sender=(
274-
self._battery_power_wrapper.proposal_channel.new_sender()
275-
),
276-
power_manager_bounds_subscription_sender=(
277-
self._battery_power_wrapper.bounds_subscription_channel.new_sender()
278-
),
279-
min_update_interval=self._resampler_config.resampling_period,
280-
batteries_id=battery_ids,
266+
ref_store_key = frozenset(battery_ids)
267+
268+
if ref_store_key not in self._battery_pool_reference_stores:
269+
self._battery_pool_reference_stores[ref_store_key] = (
270+
BatteryPoolReferenceStore(
271+
channel_registry=self._channel_registry,
272+
resampler_subscription_sender=self._resampling_request_sender(),
273+
batteries_status_receiver=(
274+
self._battery_power_wrapper.status_channel.new_receiver(limit=1)
275+
),
276+
power_manager_requests_sender=(
277+
self._battery_power_wrapper.proposal_channel.new_sender()
278+
),
279+
power_manager_bounds_subscription_sender=(
280+
self._battery_power_wrapper.bounds_subscription_channel.new_sender()
281+
),
282+
min_update_interval=self._resampler_config.resampling_period,
283+
batteries_id=battery_ids,
284+
)
281285
)
282286

283-
return BatteryPool(self._battery_pool_reference_stores[key], name, priority)
287+
return BatteryPool(
288+
self._battery_pool_reference_stores[ref_store_key], name, priority
289+
)
284290

285291
def _data_sourcing_request_sender(self) -> Sender[ComponentMetricRequest]:
286292
"""Return a Sender for sending requests to the data sourcing actor.

0 commit comments

Comments
 (0)