Forever loops: Always sleep, even if no exception occurs

Marenz · Marenz · commit 5e0bf8212c37 · 2025-06-19T10:57:37.000+02:00
We suspect that the CI is stuck because the forever loop is not sleeping when no exception occurs.

Signed-off-by: Mathias L. Baumann &lt;mathias.baumann@frequenz.com&gt;
diff --git a/src/frequenz/sdk/_internal/_asyncio.py b/src/frequenz/sdk/_internal/_asyncio.py
@@ -48,7 +48,7 @@ async def run_forever(
             await async_callable()
         except Exception:  # pylint: disable=broad-except
             _logger.exception("Restarting after exception")
-            await asyncio.sleep(interval_s)
+        await asyncio.sleep(interval_s)
 
 
 class NotSyncConstructible(AssertionError):
diff --git a/src/frequenz/sdk/microgrid/_power_distributing/_component_pool_status_tracker.py b/src/frequenz/sdk/microgrid/_power_distributing/_component_pool_status_tracker.py
@@ -119,7 +119,7 @@ async def _run(self) -> None:
                     _logger.error(
                         "ComponentPoolStatus failed with error: %s. Restarting.", err
                     )
-                    await asyncio.sleep(1.0)
+                await asyncio.sleep(1.0)
 
     async def _update_status(self) -> None:
         async for status in self._merged_status_receiver:

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ async def _run(self) -> None:`
`119`	`119`	`_logger.error(`
`120`	`120`	`"ComponentPoolStatus failed with error: %s. Restarting.", err`
`121`	`121`	`)`
`122`		`- await asyncio.sleep(1.0)`
	`122`	`+ await asyncio.sleep(1.0)`
`123`	`123`
`124`	`124`	`async def _update_status(self) -> None:`
`125`	`125`	`async for status in self._merged_status_receiver:`