Skip to content

Commit 691d6a5

Browse files
committed
Use constant BATTERY_ID instead of hardcoded number
Signed-off-by: Sahas Subramanian <[email protected]>
1 parent ccb9e29 commit 691d6a5

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tests/actor/test_battery_status.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ async def test_sync_blocking_feature(
378378

379379
# message is not correct, component should not block.
380380
tracker._handle_status_set_power_result(
381-
SetPowerResult(succeed={1}, failed={106})
381+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
382382
)
383383

384384
assert tracker._get_new_status_if_changed() is None
@@ -392,15 +392,15 @@ async def test_sync_blocking_feature(
392392
for timeout in expected_blocking_timeout:
393393
# message is not correct, component should not block.
394394
tracker._handle_status_set_power_result(
395-
SetPowerResult(succeed={1}, failed={106})
395+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
396396
)
397397

398398
assert tracker._get_new_status_if_changed() is Status.UNCERTAIN
399399

400400
# Battery should be still blocked, nothing should happen
401401
time.shift(timeout - 1)
402402
tracker._handle_status_set_power_result(
403-
SetPowerResult(succeed={1}, failed={106})
403+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
404404
)
405405

406406
assert tracker._get_new_status_if_changed() is None
@@ -416,7 +416,7 @@ async def test_sync_blocking_feature(
416416

417417
# should block for 30 sec
418418
tracker._handle_status_set_power_result(
419-
SetPowerResult(succeed={1}, failed={106})
419+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
420420
)
421421

422422
assert tracker._get_new_status_if_changed() is Status.UNCERTAIN
@@ -437,14 +437,14 @@ async def test_sync_blocking_feature(
437437

438438
# should block for 30 sec
439439
tracker._handle_status_set_power_result(
440-
SetPowerResult(succeed={1}, failed={106})
440+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
441441
)
442442
assert tracker._get_new_status_if_changed() is Status.UNCERTAIN
443443
time.shift(28)
444444

445445
# If battery succeed, then it should unblock.
446446
tracker._handle_status_set_power_result(
447-
SetPowerResult(succeed={106}, failed={206})
447+
SetPowerResult(succeed={BATTERY_ID}, failed={206})
448448
)
449449
assert tracker._get_new_status_if_changed() is Status.WORKING
450450

@@ -481,15 +481,15 @@ async def test_sync_blocking_interrupted_with_with_max_data(
481481
assert tracker._get_new_status_if_changed() is Status.WORKING
482482

483483
tracker._handle_status_set_power_result(
484-
SetPowerResult(succeed={1}, failed={106})
484+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
485485
)
486486
assert tracker._get_new_status_if_changed() is Status.UNCERTAIN
487487

488488
expected_blocking_timeout = [1, 2, 4]
489489
for timeout in expected_blocking_timeout:
490490
# message is not correct, component should not block.
491491
tracker._handle_status_set_power_result(
492-
SetPowerResult(succeed={1}, failed={106})
492+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
493493
)
494494
assert tracker._get_new_status_if_changed() is None
495495
time.shift(timeout)
@@ -527,7 +527,7 @@ async def test_sync_blocking_interrupted_with_invalid_message(
527527
assert tracker._get_new_status_if_changed() is Status.WORKING
528528

529529
tracker._handle_status_set_power_result(
530-
SetPowerResult(succeed={1}, failed={106})
530+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
531531
)
532532
assert tracker._get_new_status_if_changed() is Status.UNCERTAIN
533533

@@ -540,12 +540,12 @@ async def test_sync_blocking_interrupted_with_invalid_message(
540540
assert tracker._get_new_status_if_changed() is Status.NOT_WORKING
541541

542542
tracker._handle_status_set_power_result(
543-
SetPowerResult(succeed={1}, failed={106})
543+
SetPowerResult(succeed={1}, failed={BATTERY_ID})
544544
)
545545
assert tracker._get_new_status_if_changed() is None
546546

547547
tracker._handle_status_set_power_result(
548-
SetPowerResult(succeed={106}, failed={})
548+
SetPowerResult(succeed={BATTERY_ID}, failed={})
549549
)
550550
assert tracker._get_new_status_if_changed() is None
551551

0 commit comments

Comments
 (0)