Skip to content

Commit 85d81dd

Browse files
committed
Rename frequenz.sdk.configs and move the actor
The module frequenz.sdk.configs is renamed to frequenz.sdk.config (no "s") and the `ConfigManager` actor is moved to `frequenz.sdk.actor.ConfigManagingActor`. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent b4562c2 commit 85d81dd

File tree

12 files changed

+20
-18
lines changed

12 files changed

+20
-18
lines changed

src/frequenz/sdk/actor/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"""A base class for creating simple composable actors."""
55

66
from ._channel_registry import ChannelRegistry
7+
from ._config_managing import ConfigManagingActor
78
from ._data_sourcing import ComponentMetricRequest, DataSourcingActor
89
from ._decorator import actor
910
from ._resampling import ComponentMetricsResamplingActor
@@ -12,6 +13,7 @@
1213
"ChannelRegistry",
1314
"ComponentMetricRequest",
1415
"ComponentMetricsResamplingActor",
16+
"ConfigManagingActor",
1517
"DataSourcingActor",
1618
"actor",
1719
]

src/frequenz/sdk/configs/config_manager.py renamed to src/frequenz/sdk/actor/_config_managing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111
from frequenz.channels import Sender
1212
from frequenz.channels.util import FileWatcher
1313

14-
from ..actor import actor
15-
from .config import Config
14+
from ..actor._decorator import actor
15+
from ..config import Config
1616

1717
logger = logging.getLogger(__name__)
1818

1919

2020
@actor
21-
class ConfigManager:
21+
class ConfigManagingActor:
2222
"""
2323
Manages config variables.
2424
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33

44
"""Config interface."""
55

6-
from .config import Config
7-
from .config_manager import ConfigManager
6+
from ._config import Config
87

98
# Explicitly declare the public API.
109
__all__ = [
1110
"Config",
12-
"ConfigManager",
1311
]

src/frequenz/sdk/data_ingestion/microgrid_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from frequenz.channels.util import Merge, Select
2020

2121
from ..actor import actor
22-
from ..configs import Config
22+
from ..config import Config
2323
from ..data_handling.time_series import TimeSeriesEntry
2424
from ..microgrid.client import MicrogridApiClient
2525
from ..microgrid.graph import ComponentGraph
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
# pylint: disable = no-name-in-module
1111
from pydantic import BaseModel
1212

13-
from frequenz.sdk.configs import Config
14-
from frequenz.sdk.configs.config_manager import ConfigManager
13+
from frequenz.sdk.actor import ConfigManagingActor
14+
from frequenz.sdk.config import Config
1515

1616

1717
class Item(BaseModel):
@@ -80,7 +80,7 @@ async def test_update(self, config_file: pathlib.Path) -> None:
8080
config_channel: Broadcast[Config] = Broadcast(
8181
"Config Channel", resend_latest=True
8282
)
83-
_config_manager = ConfigManager(
83+
_config_manager = ConfigManagingActor(
8484
conf_file=str(config_file), output=config_channel.new_sender()
8585
)
8686

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import toml
1313
from pydantic import BaseModel, StrictBool, StrictFloat, StrictInt
1414

15-
from frequenz.sdk.configs.config import Config
15+
from frequenz.sdk.config import Config
1616

1717

1818
class Item(BaseModel):

tests/config/test_config_manager.py

Whitespace-only changes.

tests/data_ingestion/test_microgrid_data_config_formula_updates.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212

1313
from frequenz.channels import Broadcast
1414

15-
from frequenz.sdk.configs import Config, ConfigManager
15+
from frequenz.sdk.actor import ConfigManagingActor
16+
from frequenz.sdk.config import Config
1617
from frequenz.sdk.data_handling.time_series import TimeSeriesEntry
1718
from frequenz.sdk.data_ingestion.constants import METRIC_BATTERIES_CAPACITY
1819
from frequenz.sdk.data_ingestion.formula_calculator import FormulaCalculator
@@ -136,7 +137,7 @@ async def test_microgrid_data_config_updates(self) -> None:
136137
with NamedTemporaryFile(delete=True, dir=".") as config_file:
137138
self._write_to_file(config_file.name, config_file_initial_content)
138139

139-
_config_manager = ConfigManager(
140+
_config_manager = ConfigManagingActor(
140141
conf_file=config_file.name, output=config_update_channel.new_sender()
141142
)
142143
formula_calculator = FormulaCalculator(self.component_graph)

0 commit comments

Comments
 (0)