Fixes to the PowerDistributingActor (#1020)

Author: shsms

RELEASE_NOTES.md

@@ -40,3 +40,4 @@
 - Fixed a bug in `ConfigManagingActor` that was not properly comparing the event path to the config file path when the config file is a relative path.
 - Re-expose `ComponentMetricId` to the docs.
 - Fixed typing ambiguities when building composite formulas on streaming data.
+- Fixed a bug that was causing the `PowerDistributor` to exit if power requests to PV inverters or EV chargers timeout.

src/frequenz/sdk/actor/power_distributing/_component_managers/_ev_charger_manager/_ev_charger_manager.py

@@ -334,29 +334,29 @@ async def _set_api_power(
         succeeded_components: set[int] = set()
         failed_power = Power.zero()
         for component_id, task in tasks.items():
-            exc = task.exception()
-            if exc is not None:
-                failed_components.add(component_id)
-                failed_power += target_power_changes[component_id]
+            try:
+                task.result()
+            except asyncio.CancelledError:
+                _logger.warning(
+                    "Timeout while setting power to EV charger %s", component_id
+                )
+            except ClientError as exc:
+                _logger.warning(
+                    "Got a client error while setting power to EV charger %s: %s",
+                    component_id,
+                    exc,
+                )
+            except Exception:  # pylint: disable=broad-except
+                _logger.exception(
+                    "Unknown error while setting power to EV charger: %s", component_id
+                )
             else:
                 succeeded_components.add(component_id)
+                continue
+
+            failed_components.add(component_id)
+            failed_power += target_power_changes[component_id]
 
-            match task.exception():
-                case asyncio.CancelledError():
-                    _logger.warning(
-                        "Timeout while setting power to EV charger %s", component_id
-                    )
-                case ClientError() as err:
-                    _logger.warning(
-                        "Got a client error while setting power to EV charger %s: %s",
-                        component_id,
-                        err,
-                    )
-                case Exception():
-                    _logger.exception(
-                        "Unknown error while setting power to EV charger: %s",
-                        component_id,
-                    )
         if failed_components:
             return PartialFailure(
                 failed_components=failed_components,

src/frequenz/sdk/actor/power_distributing/_component_managers/_pv_inverter_manager/_pv_inverter_manager.py

@@ -193,29 +193,30 @@ async def _set_api_power(  # pylint: disable=too-many-locals
         succeeded_components: set[int] = set()
         failed_power = Power.zero()
         for component_id, task in tasks.items():
-            exc = task.exception()
-            if exc is not None:
-                failed_components.add(component_id)
-                failed_power += allocations[component_id]
+            try:
+                task.result()
+            except asyncio.CancelledError:
+                _logger.warning(
+                    "Timeout while setting power to PV inverter %s", component_id
+                )
+            except ClientError as exc:
+                _logger.warning(
+                    "Got a client error while setting power to PV inverter %s: %s",
+                    component_id,
+                    exc,
+                )
+            except Exception:  # pylint: disable=broad-except
+                _logger.exception(
+                    "Unknown error while setting power to PV inverter: %s",
+                    component_id,
+                )
             else:
                 succeeded_components.add(component_id)
+                continue
+
+            failed_components.add(component_id)
+            failed_power += allocations[component_id]
 
-            match task.exception():
-                case asyncio.CancelledError():
-                    _logger.warning(
-                        "Timeout while setting power to PV inverter %s", component_id
-                    )
-                case ClientError() as err:
-                    _logger.warning(
-                        "Got a client error while setting power to PV inverter %s: %s",
-                        component_id,
-                        err,
-                    )
-                case Exception():
-                    _logger.exception(
-                        "Unknown error while setting power to PV inverter: %s",
-                        component_id,
-                    )
         if failed_components:
             await self._results_sender.send(
                 PartialFailure(