Skip to content

Commit a62350c

Browse files
committed
Move sdk.data_pipeline to sdk.actor.data_sourcing
All the types left in `frequenz.sdk.data_pipeline(.types)` were specific to the data sourcing actor, so they were moved to `frequenz.sdk.data_sourcing.types` (and exported in `frequenz.sdk.data_sourcing`). The resampling actor for now is also forwarding requests to the data sourcing actor, so it also re-exports those symbols. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 479ec00 commit a62350c

File tree

9 files changed

+28
-25
lines changed

9 files changed

+28
-25
lines changed

examples/sdk_resampling_example.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,11 @@
1313

1414
from frequenz.sdk.actor import ChannelRegistry
1515
from frequenz.sdk.actor.data_sourcing import DataSourcingActor
16-
from frequenz.sdk.actor.resampling import ComponentMetricsResamplingActor
17-
from frequenz.sdk.data_pipeline import ComponentMetricId, ComponentMetricRequest
16+
from frequenz.sdk.actor.resampling import (
17+
ComponentMetricId,
18+
ComponentMetricRequest,
19+
ComponentMetricsResamplingActor,
20+
)
1821
from frequenz.sdk.microgrid import ComponentCategory, microgrid_api
1922

2023
HOST = "microgrid.sandbox.api.frequenz.io"

src/frequenz/sdk/actor/data_sourcing/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
"""
1010

1111
from .data_sourcing import DataSourcingActor
12+
from .types import ComponentMetricId, ComponentMetricRequest
1213

1314
__all__ = [
1415
"DataSourcingActor",
16+
"ComponentMetricId",
17+
"ComponentMetricRequest",
1518
]

src/frequenz/sdk/actor/data_sourcing/data_sourcing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
from frequenz.channels import Receiver
1111

12-
from ...data_pipeline import ComponentMetricRequest
1312
from .. import ChannelRegistry, actor
1413
from .microgrid_api_source import MicrogridApiSource
14+
from .types import ComponentMetricRequest
1515

1616

1717
@actor

src/frequenz/sdk/actor/data_sourcing/microgrid_api_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
from frequenz.channels import Receiver, Sender
1515

16-
from ...data_pipeline import ComponentMetricId, ComponentMetricRequest
1716
from ...microgrid import (
1817
BatteryData,
1918
ComponentCategory,
@@ -24,6 +23,7 @@
2423
)
2524
from ...timeseries import Sample
2625
from .. import ChannelRegistry
26+
from .types import ComponentMetricId, ComponentMetricRequest
2727

2828
_MeterDataMethods: Dict[ComponentMetricId, Callable[[MeterData], float]] = {
2929
ComponentMetricId.ACTIVE_POWER: lambda msg: msg.active_power,
File renamed without changes.

src/frequenz/sdk/actor/resampling.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,19 @@
1515

1616
from frequenz.channels import MergeNamed, Receiver, Select, Sender, Timer
1717

18-
from ..data_pipeline import ComponentMetricRequest
1918
from ..timeseries import GroupResampler, ResamplingFunction, Sample
20-
from . import ChannelRegistry, actor
19+
from . import ChannelRegistry, actor, data_sourcing
2120

2221
logger = logging.Logger(__name__)
2322

2423

24+
# Re-export the types from the data_sourcing actor as we use the same requests,
25+
# we are only forwarding them for now.
26+
ComponentMetricId = data_sourcing.ComponentMetricId
27+
28+
ComponentMetricRequest = data_sourcing.ComponentMetricRequest
29+
30+
2531
# pylint: disable=unused-argument
2632
def average(samples: Sequence[Sample], resampling_period_s: float) -> float:
2733
"""Calculate average of the provided values.

src/frequenz/sdk/data_pipeline/__init__.py

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/actor/test_data_sourcing.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@
1212
from frequenz.channels import Broadcast
1313

1414
from frequenz.sdk.actor import ChannelRegistry
15-
from frequenz.sdk.actor.data_sourcing import DataSourcingActor
16-
from frequenz.sdk.data_pipeline import ComponentMetricId, ComponentMetricRequest
15+
from frequenz.sdk.actor.data_sourcing import (
16+
ComponentMetricId,
17+
ComponentMetricRequest,
18+
DataSourcingActor,
19+
)
1720
from frequenz.sdk.microgrid import microgrid_api
1821
from tests.test_microgrid import mock_api
1922

tests/actor/test_resampling.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,11 @@
1313
from frequenz.channels import Broadcast
1414

1515
from frequenz.sdk.actor import ChannelRegistry
16-
from frequenz.sdk.actor.resampling import ComponentMetricsResamplingActor
17-
from frequenz.sdk.data_pipeline import ComponentMetricId, ComponentMetricRequest
16+
from frequenz.sdk.actor.resampling import (
17+
ComponentMetricId,
18+
ComponentMetricRequest,
19+
ComponentMetricsResamplingActor,
20+
)
1821
from frequenz.sdk.timeseries import Sample
1922

2023

0 commit comments

Comments
 (0)