Rename get_target_power to calculate_target_power

Also fix a typo and remove an outdated code comment.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

src/frequenz/sdk/actor/_power_managing/_base_classes.py

@@ -91,7 +91,7 @@ class Proposal:
 
     These bounds will apply to actors with a lower priority, and can be overridden by
     bounds from actors with a higher priority.  If None, the power bounds will be set to
-    the maximum power of the batteries in the pool.  This is currently and experimental
+    the maximum power of the batteries in the pool.  This is currently an experimental
     feature.
     """
 
@@ -144,7 +144,7 @@ class BaseAlgorithm(abc.ABC):
     """The base class for algorithms."""
 
     @abc.abstractmethod
-    def get_target_power(
+    def calculate_target_power(
         self,
         battery_ids: frozenset[int],
         proposal: Proposal | None,

src/frequenz/sdk/actor/_power_managing/_matryoshka.py

@@ -123,7 +123,7 @@ def _validate_battery_ids(
         return True
 
     @override
-    def get_target_power(
+    def calculate_target_power(
         self,
         battery_ids: frozenset[int],
         proposal: Proposal | None,

src/frequenz/sdk/actor/_power_managing/_power_managing_actor.py

@@ -148,7 +148,7 @@ async def _send_updated_target_power(
     ) -> None:
         from .. import power_distributing  # pylint: disable=import-outside-toplevel
 
-        target_power = self._algorithm.get_target_power(
+        target_power = self._algorithm.calculate_target_power(
             battery_ids,
             proposal,
             self._system_bounds[battery_ids],

tests/actor/_power_managing/test_matryoshka.py

@@ -35,7 +35,7 @@ def test_tgt_power(
     ) -> None:
         nonlocal call_count
         call_count += 1
-        tgt_power = algorithm.get_target_power(
+        tgt_power = algorithm.calculate_target_power(
             batteries,
             Proposal(
                 battery_ids=batteries,

tests/timeseries/_battery_pool/test_battery_pool_control_methods.py

@@ -180,11 +180,6 @@ async def test_case_1(
 
         battery_pool = microgrid.battery_pool()
 
-        # This is used just to wait for the processing to be complete.  The results are
-        # not used.
-        #
-        # It will be replaced by a reporting streaming from the PowerManager in a
-        # subsequent commit.
         bounds_rx = battery_pool.power_status.new_receiver()
 
         self._assert_report(