Skip to content

Commit c869167

Browse files
committed
Fix sample ordering in tests
The resampler expects samples to be in order (from older to newer), otherwise when calculating which samples are relevant to the current resampling window some valid samples could be left out. Some tests didn't have them in the proper order but they were working just by chance. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent d229088 commit c869167

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/timeseries/test_resampling.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,21 +99,21 @@ def test_component_metric_resampler_resample_with_outdated_samples() -> None:
9999

100100
timestamp = datetime.now(timezone.utc)
101101

102-
value3 = 100.0
103-
value1 = 5.0
102+
value1 = 100.0
104103
value2 = 15.0
104+
value3 = 5.0
105105

106-
sample3 = Sample(timestamp - timedelta(seconds=1.01), value=value3)
107-
sample1 = Sample(timestamp - timedelta(seconds=0.5), value=value1)
106+
sample1 = Sample(timestamp - timedelta(seconds=1.01), value=value1)
108107
sample2 = Sample(timestamp - timedelta(seconds=0.7), value=value2)
108+
sample3 = Sample(timestamp - timedelta(seconds=0.5), value=value3)
109109

110-
resampler.add_sample(sample3)
111110
resampler.add_sample(sample1)
112111
resampler.add_sample(sample2)
112+
resampler.add_sample(sample3)
113113

114114
value = resampler.resample()
115115
assert value is not None
116-
assert value == sum([value1, value2])
116+
assert value == sum([value2, value3])
117117

118118

119119
@time_machine.travel(datetime.now())
@@ -138,8 +138,8 @@ def test_component_metric_group_resampler() -> None:
138138
value3 = 100.0
139139
value4 = 999.0
140140

141-
sample1 = Sample(timestamp - timedelta(seconds=0.5), value=value1)
142-
sample2 = Sample(timestamp - timedelta(seconds=0.7), value=value2)
141+
sample1 = Sample(timestamp - timedelta(seconds=0.7), value=value1)
142+
sample2 = Sample(timestamp - timedelta(seconds=0.5), value=value2)
143143
sample3 = Sample(timestamp - timedelta(seconds=5.05), value=value3)
144144
sample4 = Sample(timestamp - timedelta(seconds=0.99), value=value4)
145145

0 commit comments

Comments
 (0)