Avoid disabling some pylint checks when unnecessary

Signed-off-by: Leandro Lucarella <[email protected]>

Author: llucax

benchmarks/power_distribution/power_distributor.py

@@ -137,8 +137,6 @@ async def run_test(  # pylint: disable=too-many-locals
 
 async def run() -> None:
     """Create microgrid api and run tests."""
-    # pylint: disable=protected-access
-
     await microgrid.initialize(
         "grpc://microgrid.sandbox.api.frequenz.io:62060",
         ResamplerConfig(resampling_period=timedelta(seconds=1.0)),

benchmarks/timeseries/benchmark_datasourcing.py

@@ -49,12 +49,12 @@ def enable_mock_client(client: MockMicrogridClient) -> None:
     Args:
         client: the mock microgrid client to enable.
     """
-    # pylint: disable=protected-access
-    microgrid.connection_manager._CONNECTION_MANAGER = client.mock_microgrid
+    microgrid.connection_manager._CONNECTION_MANAGER = (  # pylint: disable=protected-access
+        client.mock_microgrid
+    )
 
 
-# pylint: disable=too-many-locals
-async def benchmark_data_sourcing(
+async def benchmark_data_sourcing(  # pylint: disable=too-many-locals
     num_ev_chargers: int, num_msgs_per_battery: int
 ) -> None:
     """Benchmark the data sourcing actor.

src/frequenz/sdk/actor/power_distributing/_component_status/_battery_status_tracker.py

@@ -398,6 +398,7 @@ def _is_inverter_state_correct(self, msg: InverterData) -> bool:
                     state.name,
                 )
             return False
+        # pylint: enable=protected-access
         return True
 
     def _is_battery_state_correct(self, msg: BatteryData) -> bool:
@@ -422,7 +423,6 @@ def _is_battery_state_correct(self, msg: BatteryData) -> bool:
             return False
 
         # Component state is not exposed to the user.
-        # pylint: disable=protected-access
         relay_state = msg.relay_state
         if relay_state not in BatteryStatusTracker._battery_valid_relay:
             if self._last_status == ComponentStatusEnum.WORKING:
@@ -433,6 +433,7 @@ def _is_battery_state_correct(self, msg: BatteryData) -> bool:
                 )
             return False
         return True
+        # pylint: enable=protected-access
 
     def _is_timestamp_outdated(self, timestamp: datetime) -> bool:
         """Return if timestamp is to old.

src/frequenz/sdk/microgrid/component_graph.py

@@ -1037,11 +1037,12 @@ def _correct_graph_errors(graph: _MicrogridComponentGraph) -> None:
     # This is an expected case from the API: that no explicit
     # grid endpoint will be provided, but that components connected
     # to the grid endpoint will have node 0 as their predecessor.
+    # pylint: disable=protected-access
     if (
-        graph._graph.has_node(0)  # pylint: disable=protected-access
-        and graph._graph.in_degree(0) == 0  # pylint: disable=protected-access
-        and graph._graph.out_degree(0) > 0  # pylint: disable=protected-access
-        and "type" not in graph._graph.nodes[0]  # pylint: disable=protected-access
+        graph._graph.has_node(0)
+        and graph._graph.in_degree(0) == 0
+        and graph._graph.out_degree(0) > 0
+        and "type" not in graph._graph.nodes[0]
     ):
-        # pylint: disable=protected-access
         graph._graph.add_node(0, **asdict(Component(0, ComponentCategory.GRID)))
+    # pylint: enable=protected-access

tests/actor/test_config_manager.py

@@ -6,8 +6,6 @@
 
 import pytest
 from frequenz.channels import Broadcast
-
-# pylint: disable = no-name-in-module
 from pydantic import BaseModel
 
 from frequenz.sdk.actor import ConfigManagingActor

tests/timeseries/test_resampling.py

@@ -253,7 +253,6 @@ async def test_calculate_window_end_trivial_cases(
     # pylint: disable=protected-access
     none_result = resampler_none._calculate_window_end()
     assert resampler_now._calculate_window_end() == none_result
-    # pylint: disable=protected-access
     assert none_result[0] == now + resampling_period
 
 

tests/timeseries/test_ringbuffer.py

@@ -166,7 +166,6 @@ def test_timestamp_ringbuffer_missing_parameter(
     """Test ordered ring buffer."""
     buffer.update(Sample(datetime(2, 2, 2, 0, 0, tzinfo=timezone.utc), Quantity(0)))
 
-    # pylint: disable=protected-access
     assert buffer.normalize_timestamp(buffer.gaps[0].start) == buffer.gaps[0].start
 
     # Expecting one gap now, made of all the previous entries of the one just
@@ -175,7 +174,6 @@ def test_timestamp_ringbuffer_missing_parameter(
     assert buffer.gaps[0].end == datetime(2, 2, 2, tzinfo=timezone.utc)
 
     # Add entry so that a second gap appears
-    # pylint: disable=protected-access
     assert buffer.normalize_timestamp(
         datetime(2, 2, 2, 0, 7, 31, tzinfo=timezone.utc)
     ) == datetime(2, 2, 2, 0, 10, tzinfo=timezone.utc)
@@ -333,11 +331,9 @@ def test_timestamp_ringbuffer_missing_parameter_smoke(
         expected_gaps = list(
             map(
                 lambda x: Gap(
-                    # pylint: disable=protected-access
                     start=buffer.normalize_timestamp(
                         datetime.fromtimestamp(200 + x[0] * resolution, tz=timezone.utc)
                     ),
-                    # pylint: disable=protected-access
                     end=buffer.normalize_timestamp(
                         datetime.fromtimestamp(200 + x[1] * resolution, tz=timezone.utc)
                     ),

tests/timeseries/test_ringbuffer_serialization.py

@@ -45,23 +45,17 @@ def load_dump_test(dumped: rb.OrderedRingBuffer[Any], path: str) -> None:
     rb.dump(dumped, path)
 
     # Load old data
-    # pylint: disable=protected-access
     loaded = rb.load(path)
     assert loaded is not None
 
     np.testing.assert_equal(dumped[:], loaded[:])
 
     # pylint: disable=protected-access
     assert dumped._timestamp_oldest == loaded._timestamp_oldest
-    # pylint: disable=protected-access
     assert dumped._timestamp_newest == loaded._timestamp_newest
-    # pylint: disable=protected-access
     assert len(dumped._gaps) == len(loaded._gaps)
-    # pylint: disable=protected-access
     assert dumped._gaps == loaded._gaps
-    # pylint: disable=protected-access
     assert dumped._sampling_period == loaded._sampling_period
-    # pylint: disable=protected-access
     assert dumped._time_index_alignment == loaded._time_index_alignment
 
 

tests/utils/component_data_wrapper.py

@@ -92,7 +92,7 @@ def copy_with_new_timestamp(self, new_timestamp: datetime) -> BatteryDataWrapper
 class InverterDataWrapper(InverterData):
     """Wrapper for the InverterData with default arguments."""
 
-    def __init__(  # pylint: disable=too-many-arguments
+    def __init__(  # pylint: disable=too-many-arguments,too-many-locals
         self,
         component_id: int,
         timestamp: datetime,