Remove states method for streaming ev charger state changes

This will be replaced by a method that streams states along with power
and current metrics for individual ev chargers.

Signed-off-by: Sahas Subramanian <[email protected]>

Author: shsms

src/frequenz/sdk/timeseries/ev_charger_pool/__init__.py

@@ -4,10 +4,7 @@
 """Interactions with EV Chargers."""
 
 from ._ev_charger_pool import EVChargerPool
-from ._state_tracker import EVChargerPoolStates, EVChargerState
 
 __all__ = [
     "EVChargerPool",
-    "EVChargerPoolStates",
-    "EVChargerState",
 ]

src/frequenz/sdk/timeseries/ev_charger_pool/_ev_charger_pool.py

@@ -8,7 +8,7 @@
 import logging
 import uuid
 
-from frequenz.channels import Receiver, Sender
+from frequenz.channels import Sender
 
 from ... import microgrid
 from ...actor import ChannelRegistry, ComponentMetricRequest
@@ -19,7 +19,6 @@
     EVChargerPowerFormula,
     FormulaGeneratorConfig,
 )
-from ._state_tracker import EVChargerPoolStates, StateTracker
 
 logger = logging.getLogger(__name__)
 
@@ -61,29 +60,13 @@ def __init__(
                     component_category={ComponentCategory.EV_CHARGER}
                 )
             }
-        self._state_tracker: StateTracker | None = None
         self._namespace = f"ev-charger-pool-{uuid.uuid4()}"
         self._formula_pool = FormulaEnginePool(
             self._namespace,
             self._channel_registry,
             self._resampler_subscription_sender,
         )
 
-    async def _stop(self) -> None:
-        if self._state_tracker:
-            await self._state_tracker.stop()
-
-    def states(self) -> Receiver[EVChargerPoolStates]:
-        """Return a receiver that streams ev charger states.
-
-        Returns:
-            A receiver that streams the states of all ev chargers in the pool, every
-                time the states of any of them change.
-        """
-        if not self._state_tracker:
-            self._state_tracker = StateTracker(self._component_ids)
-        return self._state_tracker.new_receiver()
-
     async def total_current(self) -> FormulaReceiver3Phase:
         """Fetch the total current for the ev chargers in the pool.
 

tests/timeseries/test_ev_charger_pool.py

@@ -14,10 +14,11 @@
 
 from frequenz.sdk import microgrid
 from frequenz.sdk.microgrid.component import ComponentMetricId
-from frequenz.sdk.timeseries.ev_charger_pool import (
-    EVChargerPool,
+from frequenz.sdk.timeseries.ev_charger_pool import EVChargerPool
+from frequenz.sdk.timeseries.ev_charger_pool._state_tracker import (
     EVChargerPoolStates,
     EVChargerState,
+    StateTracker,
 )
 from frequenz.sdk.timeseries.logical_meter import LogicalMeter
 from tests.timeseries._formula_engine.utils import (
@@ -35,11 +36,10 @@ async def test_state_updates(self, mocker: MockerFixture) -> None:
 
         mockgrid = MockMicrogrid(grid_side_meter=False, sample_rate_s=0.01)
         mockgrid.add_ev_chargers(5)
-        request_chan, channel_registry = await mockgrid.start(mocker)
-
-        pool = EVChargerPool(channel_registry, request_chan.new_sender())
+        await mockgrid.start(mocker)
 
-        states = pool.states()
+        state_tracker = StateTracker(set(mockgrid.evc_ids))
+        states = state_tracker.new_receiver()
 
         async def check_next_state(
             expected: dict[int, EVChargerState],
@@ -85,7 +85,7 @@ async def check_next_state(
         expected_states[evc_1_id] = EVChargerState.ERROR
         await check_next_state(expected_states, (evc_1_id, EVChargerState.ERROR))
 
-        await pool._stop()  # pylint: disable=protected-access
+        await state_tracker.stop()
         await mockgrid.cleanup()
 
     async def test_ev_power(  # pylint: disable=too-many-locals