Start following Google style imports #209
Closed
leandro-lucarella-frequenz
started this conversation in
Ideas
Replies: 2 comments
-
No :) |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'll try to implement this (pylint plugin to enforce it): https://pypi.org/project/pylint-google-style-guide-imports-enforcing/. Moving to an issue: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We definitely have a style issue here, even when we say we are using Google style, explictly mentioning import style, we are really not.
Right now we are using mostly a style that allows us to import symbols directly, without a namespace.
So google style example:
Current style (mostly):
I think we need to decide for one and stick with it (and update the docs if necessary). I prefer to stick to Google style because otherwise we need to add exceptions to Google style as we want to follow it in general. Also is a little less typing (but harder to get context if you don't have the source file name at hand).
This should apply (probably) only to new code, and with time we can update old code progressively.
@frequenz-floss/python-sdk-team anyone opposing to be more aggressive towards following Google's import style?
Coming from #208 (comment)
Beta Was this translation helpful? Give feedback.
All reactions