Skip to content

Remove obsolete hpack logging adjustment from examples/battery_pool.pyΒ #1246

@llucax

Description

@llucax

What's needed?

Remove the following lines from examples/battery_pool.py, as they are no longer necessary:

    # Reduce undesired noise from hpack
    logging.getLogger("hpack.hpack").setLevel(logging.INFO)

These lines were introduced as a workaround for noise produced by betterproto, but since the project has moved away from betterproto, they are now obsolete.

Proposed solution

Deleting the two lines from examples/battery_pool.py will resolve the issue and simplify the script.

Use cases

  • Prevents confusion for future maintainers by removing obsolete code.
  • Keeps the example script clean and up to date with current project dependencies.

Alternatives and workarounds

Alternatives include leaving the lines in place, but that would continue to serve no purpose and may mislead developers.

Additional context

Context: This adjustment was needed only when betterproto was used. The dependency has been dropped for some time now, making these lines unnecessary.

Metadata

Metadata

Assignees

Labels

type:enhancementNew feature or enhancement visitble to users

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions