-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
Technical Debt
Copy link
Labels
type:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Milestone
Description
What's needed?
Remove the following lines from examples/battery_pool.py, as they are no longer necessary:
# Reduce undesired noise from hpack
logging.getLogger("hpack.hpack").setLevel(logging.INFO)These lines were introduced as a workaround for noise produced by betterproto, but since the project has moved away from betterproto, they are now obsolete.
Proposed solution
Deleting the two lines from examples/battery_pool.py will resolve the issue and simplify the script.
Use cases
- Prevents confusion for future maintainers by removing obsolete code.
- Keeps the example script clean and up to date with current project dependencies.
Alternatives and workarounds
Alternatives include leaving the lines in place, but that would continue to serve no purpose and may mislead developers.
Additional context
Context: This adjustment was needed only when betterproto was used. The dependency has been dropped for some time now, making these lines unnecessary.
Copilot
Metadata
Metadata
Labels
type:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Type
Projects
Status
Done