Store the original Component and Connection in the component graph
#1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llucax
requested review from
daniel-zullo-frequenz
and removed request for
a team
github-actions
bot
added
part:tests
llucax
force-pushed
the
component-graph-nodes
branch
from
82d3016 to
35a4a80
Compare
llucax
changed the title
Component and Connection in the component graph
llucax
added
type:tech-debt
|
Skipping release notes as it is invisible to the user. |
|
IIUC this PR is fixing #789. If that's the case, it should be mentioned in the PR description |
For some reason the Component and Connection objects were converted to `dict` to store them in the component graph. This requires re-building the objects when they need to be extracted, which is wasteful. It also means that type information is lost, and in the future, when adopting the microgrid API client using v0.17, we have a class hierarchy for components instead of relaying in the category and type, so we would even need to store the type if we wanted to rebuild the objects. Having nested objects is also an issue, as then the nested properties were kept as `dict`, adding an inconsistency and making it type-unsafe. With this change we are able to get rid of a hack to retrieve the grid metadata. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
There is plenty we can still do without the metadata, so completely disabling access to the grid connection point if we don't have metadata is too strict. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Co-authored-by: Daniel Zullo <[email protected]> Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
component-graph-nodes
branch
from
35a4a80 to
90e2131
Compare
|
Updated with the suggested fixes. |
daniel-zullo-frequenz
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the Component and Connection objects were converted to
dictto store them in the component graph. This requires re-building the objects when they need to be extracted, which is wasteful.It also means that type information is lost, and in the future, when adopting the microgrid API client using v0.17, we have a class hierarchy for components instead of relaying in the category and type, so we would even need to store the type if we wanted to rebuild the objects.
Having nested objects is also an issue, as then the nested properties were kept as
dict, adding an inconsistency and making it type-unsafe.With this change we are able to get rid of a hack to retrieve the grid metadata.
Fixes #789.