Fix succeeded_power calculation in PV power distribution
#1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported incorrectly earlier using a variable that was never set. That variable and related (unused) channels have been removed. This also updates the PV pool tests to ensure that the distribution results are accurate. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect calculation of succeeded_power during PV power distribution and removes unused variables/channels.
- Updates the succeeded_power logic in the PV inverter manager to subtract both failed and remaining power.
- Adjusts test assertions and expected values in the PV pool tests to reflect the new calculation.
- Revises release notes to document the correction.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/timeseries/_pv_pool/test_pv_pool_control_methods.py | Updated test assertions and expected values to match the new succeeded_power calculation. |
| src/frequenz/sdk/microgrid/_power_distributing/_component_managers/_pv_inverter_manager/_pv_inverter_manager.py | Revised succeeded_power calculation by switching from self._target_power to request.power and adjusting for remaining power. |
| RELEASE_NOTES.md | Updated release notes to accurately document the bug fix and expected behavior. |
Comments suppressed due to low confidence (1)
tests/timeseries/_pv_pool/test_pv_pool_control_methods.py:303
- [nitpick] Consider adding additional tests to cover edge cases where the request.power significantly deviates from component defaults, ensuring comprehensive coverage of the new succeeded_power logic.
await pv_pool.propose_power(Power.from_watts(-200000.0))
| succeeded_components=succeeded_components, | ||
| failed_power=failed_power, | ||
| succeeded_power=self._target_power - failed_power, | ||
| succeeded_power=request.power - failed_power - remaining_power, |
There was a problem hiding this comment.
[nitpick] Consider adding a brief comment or updating the docstring here to clarify why the succeeded_power is calculated as request.power minus both the failed_power and remaining_power.
| Success( | ||
| succeeded_components=succeeded_components, | ||
| succeeded_power=self._target_power, | ||
| succeeded_power=request.power - remaining_power, |
There was a problem hiding this comment.
[nitpick] A comment explaining why the succeeded_power calculation in this branch excludes failed_power (compared to the previous branch) would improve maintainability and clarity.
Marenz
approved these changes
May 15, 2025
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported incorrectly earlier using a variable that was never
set. That variable and related (unused) channels have been removed.
This also updates the PV pool tests to ensure that the distribution
results are accurate.