Update tests to support latest time-machine #1221
Merged
+52
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test suite to support the latest version of time-machine (v2.16.0) and introduces an async event loop policy via async_solipsism to align with the updated dependencies.
- Updated time-machine dependency in pyproject.toml.
- Added an import for async_solipsism and a new pytest fixture (event_loop_policy) to configure the event loop.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/microgrid/power_distributing/_component_status/test_battery_status.py | Added async_solipsism import and an event_loop_policy fixture for handling asynchronous tests. |
| pyproject.toml | Updated the time-machine dependency to v2.16.0. |
tests/microgrid/power_distributing/_component_status/test_battery_status.py
Show resolved
Hide resolved
llucax
reviewed
May 16, 2025
And migrate to latest time-machine version v2.16.0 This new version of `time-machine` mocks the monotonic clock of asyncio. This was causing the `test_battery_status.py::TestBatteryStatus::test_async_battery_status` test to fail, because `channels.Timer`s weren't working properly. To fix this, this commit switches this test file to use an `async_solipsism` event loop instead, which `time-machine` doesn't affect. But introducing the `async_solipsism` event loop caused the `TestBatteryStatusRecovery::test_stale_data` test to fail, because it needed the clock time to make progress, which wasn't happening because `sleep` was returning immediately. To fix this, this commit also updates that test to use `time-machine` and moves the time forward manually, so the test can pass. Signed-off-by: Sahas Subramanian <[email protected]>
done |
llucax
approved these changes
May 16, 2025
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And migrate to latest time-machine version v2.16.0
This new version of
time-machinemocks the monotonic clock ofasyncio.
This was causing the
test_battery_status.py::TestBatteryStatus::test_async_battery_statustest to fail, because
channels.Timers weren't working properly.To fix this, this commit switches this test file to use an
async_solipsismevent loop instead, whichtime-machinedoesn'taffect.
But introducing the
async_solipsismevent loop caused theTestBatteryStatusRecovery::test_stale_datatest to fail, because itneeded the clock time to make progress, which wasn't happening because
sleepwas returning immediately.To fix this, this commit also updates that test to use
time-machineand moves the time forward manually, so the test can pass.