Switched to httplug implementation

Author: Evert Harmeling

.travis.yml

@@ -4,9 +4,10 @@ php:
     - 5.5
     - 5.6
     - 7.0
+    - 7.1
 
 before_script:
-    - composer install --dev
+    - composer install
 
 script: phpunit --coverage-text
 

CHANGELOG.md

@@ -1,7 +1,8 @@
 # CHANGELOG
 
-## 2.1.0
+## 3.0.0
 
+* Dropped direct usage of Guzzle and now make use of [HTTPPlug](http://httplug.io/), see README.
 * Added `getPostcodes()` call, to get postcodes based on provided `latitude, longitude`. Note that this call is only available with a premium account.
 
 ## 2.0.0

README.md

@@ -14,7 +14,7 @@ by [Freshheads](https://www.freshheads.com) and will be maintained in sync with
 Requirements
 ------------
 
-FHPostcodeAPIClient works with PHP 5.4.0 or up. This library is dependent on the awesome [Guzzle](http://guzzlephp.org/) HTTP client library. 
+FHPostcodeAPIClient works with PHP 5.5.0 or up. This library depends on the [HTTPPlug](http://httplug.io/), see http://docs.php-http.org/en/latest/httplug/introduction.html. 
 
 Installation
 ------------
@@ -36,7 +36,16 @@ require_once 'vendor/autoload.php';
 
 // initiate client
 $apiKey = 'replace_with_your_own_api_key';
-$client = new \FH\PostcodeAPI\Client(new \GuzzleHttp\Client(), $apiKey);
+// In this example we made use of the Guzzle6 as HTTPClient in combination with an HTTPPlug compatible adapter.
+$client = new \FH\PostcodeAPI\Client(
+    new Http\Adapter\Guzzle6\Client(
+        new GuzzleHttp\Client([
+            'headers' => [
+                'X-Api-Key' => $apiKey
+            ]
+        ])
+    )
+);
 
 // call endpoints
 $response = $client->getAddresses('5041EB', 21);
@@ -46,4 +55,38 @@ $response = $client->getAddress('0855200000061001');
 $response = $client->getPostcodes('51.566405', '5.077171');
 ```
 
-[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/freshheads/fhpostcodeapiclient/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+Note that to be able to run the example above you should have ran the following command, to have Guzzle6 and the Adapter available.
+
+```bash
+composer require php-http/guzzle6-adapter
+```
+
+Within Symfony project
+----------------------
+
+We recommend to use [Guzzle](https://github.com/guzzle/guzzle), to be able to use Guzzle in combination with the PostcodeApiClient you should also make use of the 
+[Guzzle6Adapter](https://github.com/php-http/guzzle6-adapter). By running the following command you automatically install Guzzle aswel.
+
+```bash
+composer require php-http/guzzle6-adapter
+```
+
+And add the following service definitions:
+```yaml
+project.http.guzzle.client:
+    class: GuzzleHttp\Client
+    arguments:
+        - { headers: { X-Api-Key: 'replace_with_your_own_api_key' } }
+
+project.http.adapter.guzzle.client:
+    class: Http\Adapter\Guzzle6\Client
+    arguments:
+        - '@project.http.guzzle.client'
+        
+project.client.postal_code:
+    class: FH\PostcodeAPI\Client
+    arguments:
+        - '@project.http.adapter.guzzle.client'
+```
+
+You should now be able use the `project.client.postal_code` service to make requests to the PostcodeAPI.

composer.json

@@ -17,10 +17,15 @@
     ],
     "require": {
         "php": ">=5.4.0",
-        "guzzlehttp/guzzle": "^6.0"
+        "php-http/httplug": "^1.1",
+        "guzzlehttp/psr7": "^1.3"
     },
     "require-dev": {
-        "phpunit/phpunit": "^4.3.5"
+        "phpunit/phpunit": "^4.3.5|^5.0",
+        "php-http/mock-client": "^0.3.0"
+    },
+    "suggest": {
+        "php-http/guzzle6-adapter": "An HTTPlug adapter for the Guzzle 6 HTTP client"
     },
     "autoload": {
         "psr-0": { "FH\\PostcodeAPI": "lib/" }
@@ -29,5 +34,8 @@
         "branch-alias": {
             "dev-master": "3.0.x-dev"
         }
+    },
+    "scripts": {
+        "test": "./vendor/phpunit/phpunit/phpunit --coverage-text"
     }
 }

lib/FH/PostcodeAPI/Client.php

@@ -3,46 +3,43 @@
 namespace FH\PostcodeAPI;
 
 use FH\PostcodeAPI\Exception\CouldNotParseResponseException;
-use GuzzleHttp\Client as HTTPClient;
-use GuzzleHttp\ClientInterface;
-use GuzzleHttp\Exception\RequestException;
+use FH\PostcodeAPI\Exception\InvalidApiKeyException;
+use FH\PostcodeAPI\Exception\ServerErrorException;
 use GuzzleHttp\Psr7\Request;
+use Http\Client\HttpClient;
+use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 
 /**
  * Client library for postcodeapi.nu 2.0 web service.
  *
  * @author Gijs Nieuwenhuis <gijs.nieuwenhuis@freshheads.com>
+ * @author Evert Harmeling <evert@freshheads.com>
  */
 class Client
 {
     const POSTCODES_SORT_DISTANCE = 'distance';
 
-    /**
-     * @var string
-     */
-    private $uriScheme  = 'https://';
-
     /**
      * @var null|string
      */
-    private $domain     = 'postcode-api.apiwise.nl';
+    private $url = 'https://postcode-api.apiwise.nl';
 
     /**
      * @var string
      */
-    private $version    = 'v2';
+    private $version = 'v2';
 
     /**
-     * @var HTTPClient
+     * @var HttpClient
      */
     private $httpClient;
 
 
-    public function __construct(ClientInterface $httpClient, $domain = null)
+    public function __construct(HttpClient $httpClient, $url = null)
     {
-        if (null !== $domain) {
-            $this->domain = $domain;
+        if (null !== $url) {
+            $this->url = $url;
         }
 
         $this->httpClient = $httpClient;
@@ -94,39 +91,28 @@ public function getPostcodesByCoordinates($latitude, $longitude, $sort = self::P
 
     /**
      * @param string $path
-     * @param array $queryParams
+     * @param array $params
      *
      * @return \stdClass
      *
      * @throws RequestException
      */
-    private function get($path, array $queryParams = array())
+    private function get($path, array $params = [])
     {
-        $request = $this->createHttpRequest('GET', sprintf('%s%s/%s%s', $this->uriScheme, $this->domain, $this->version, $path),
-            $queryParams
-        );
+        $request = $this->createHttpGetRequest($this->buildUrl($path), $params);
 
-        $response = $this->httpClient->send($request);
+        $response = $this->httpClient->sendRequest($request);
 
-        return $this->parseResponse($response);
+        return $this->parseResponse($response, $request);
     }
 
     /**
-     * @param ResponseInterface $response
-     *
-     * @return \stdClass
-     *
-     * @throws CouldNotParseResponseException
+     * @param string $path
+     * @return string
      */
-    private function parseResponse(ResponseInterface $response)
+    private function buildUrl($path)
     {
-        $out = json_decode((string) $response->getBody());
-
-        if (json_last_error() !== JSON_ERROR_NONE) {
-            throw new CouldNotParseResponseException('Could not parse response', $response);
-        }
-
-        return $out;
+        return sprintf('%s/%s%s', $this->url, $this->version, $path);
     }
 
     /**
@@ -136,10 +122,37 @@ private function parseResponse(ResponseInterface $response)
      *
      * @return Request
      */
-    private function createHttpRequest($method, $url, array $queryParams = array())
+    private function createHttpGetRequest($url, array $params = [])
     {
-        $url = $url . (count($queryParams) > 0 ? '?' . http_build_query($queryParams) : '');
+        $url .= (count($params) > 0 ? '?' . http_build_query($params, null, '&', PHP_QUERY_RFC3986) : '');
+
+        return new Request('GET', $url);
+    }
+
+    /**
+     * @param ResponseInterface $response
+     *
+     * @return \stdClass
+     *
+     * @throws CouldNotParseResponseException
+     */
+    private function parseResponse(ResponseInterface $response, RequestInterface $request)
+    {
+        $result = json_decode((string) $response->getBody()->getContents());
+
+        if (json_last_error() !== JSON_ERROR_NONE) {
+            throw new CouldNotParseResponseException('Could not parse response', $response);
+        }
+
+        if (property_exists($result, 'error')) {
+            switch ($result->error) {
+                case 'API key is invalid.':
+                    throw new InvalidApiKeyException();
+                case 'An unknown server error occured.':
+                    throw ServerErrorException::fromRequest($request);
+            }
+        }
 
-        return new Request($method, $url);
+        return $result;
     }
 }

lib/FH/PostcodeAPI/Exception/CouldNotParseResponseException.php

@@ -7,7 +7,7 @@
 /**
  * @author Gijs Nieuwenhuis <gijs.nieuwenhuis@freshheads.com>
  */
-final class CouldNotParseResponseException extends \Exception
+final class CouldNotParseResponseException extends \Exception implements PostcodeApiExceptionInterface
 {
     /**
      * @var ResponseInterface

lib/FH/PostcodeAPI/Exception/InvalidApiKeyException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace FH\PostcodeAPI\Exception;
+
+/**
+ * @author Evert Harmeling <evert@freshheads.com>
+ */
+class InvalidApiKeyException extends \Exception implements PostcodeApiExceptionInterface
+{
+}

lib/FH/PostcodeAPI/Exception/PostcodeApiExceptionInterface.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace FH\PostcodeAPI\Exception;
+
+/**
+ * @author Evert Harmeling <evert@freshheads.com>
+ */
+interface PostcodeApiExceptionInterface
+{
+}

lib/FH/PostcodeAPI/Exception/ServerErrorException.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace FH\PostcodeAPI\Exception;
+
+use Psr\Http\Message\RequestInterface;
+
+/**
+ * @author Evert Harmeling <evert@freshheads.com>
+ */
+class ServerErrorException extends \Exception implements PostcodeApiExceptionInterface
+{
+    /**
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @param RequestInterface $request
+     * @return ServerErrorException
+     */
+    public function setRequest($request)
+    {
+        $this->request = $request;
+
+        return $this;
+    }
+
+    /**
+     * @return RequestInterface
+     */
+    public function getRequest()
+    {
+        return $this->request;
+    }
+
+    /**
+     * @param RequestInterface $request
+     * @return ServerErrorException
+     */
+    public static function fromRequest(RequestInterface $request)
+    {
+        $self = new self();
+        $self->setRequest($request);
+
+        return $self;
+    }
+}