Use window.scrollTo instead of smooth scrolling as this is somewhat confusing for the client

Author: Gijs Nieuwenhuis

src/react/hooks/__tests__/useScrollToTopOnDependencyChange.test.ts

@@ -2,23 +2,23 @@ import { renderHook, act } from '@testing-library/react-hooks';
 import useScrollToTopOnDependencyChange from '../useScrollToTopOnDependencyChange';
 
 describe('useScrollToTopOnDependencyChange', () => {
-    let oldWindowScroll: Function;
+    let oldWindowScrollTo: Function;
 
     beforeEach(() => {
-        oldWindowScroll = window.scroll;
-        window.scroll = jest.fn();
+        oldWindowScrollTo = window.scrollTo;
+        window.scrollTo = jest.fn();
     });
 
     afterEach(() => {
         // @ts-ignore => cannot copy type of window.scroll somehow
-        window.scroll = oldWindowScroll;
+        window.scrollTo = oldWindowScrollTo;
     });
 
     describe('on mount', () => {
         it('should execute window.scroll', () => {
             renderHook(() => useScrollToTopOnDependencyChange());
 
-            expect(window.scroll).toBeCalledTimes(1);
+            expect(window.scrollTo).toBeCalledTimes(1);
         });
     });
 
@@ -34,7 +34,7 @@ describe('useScrollToTopOnDependencyChange', () => {
             depedencies = ['second'];
             rerender();
 
-            expect(window.scroll).toBeCalledTimes(2);
+            expect(window.scrollTo).toBeCalledTimes(2);
         });
     });
 });

src/react/hooks/useScrollToTopOnDependencyChange.ts

@@ -3,13 +3,5 @@ import { useEffect } from 'react';
 export default function useScrollToTopOnDependencyChange(
     ...dependencies: any[]
 ): void {
-    useEffect(
-        () =>
-            window.scroll({
-                top: 0,
-                left: 0,
-                behavior: 'smooth',
-            }),
-        dependencies
-    );
+    useEffect(() => window.scrollTo(0, 0), dependencies);
 }