Fix inspection issues

Author: freya022

BotCommands-core/src/main/java/io/github/freya022/botcommands/api/BCInfo.java

@@ -24,7 +24,6 @@ public class BCInfo {
     public static final String COMMIT_HASH;
     public static final String BUILD_JDA_VERSION;
 
-    @SuppressWarnings("ConstantConditions")
     public static final String VERSION;
 
     static {

BotCommands-core/src/main/java/io/github/freya022/botcommands/api/localization/providers/LocalizationMapProviders.java

@@ -64,7 +64,7 @@ public LocalizationMap cycleProvidersWithParents(String baseName, Locale locale)
                     return bundle;
                 }
             } catch (Exception e) {
-                LOGGER.error("An error occurred while getting a bundle '{}' with locale '{}' with provider '{}'", baseName, locale, provider.getClass().getName());
+                LOGGER.warn("An error occurred while getting a bundle w/ parents '{}' with locale '{}' with provider '{}'", baseName, locale, provider.getClass().getName(), e);
             }
         }
 
@@ -94,7 +94,7 @@ public LocalizationMap cycleProviders(String baseName, Locale locale) {
                     return bundle;
                 }
             } catch (Exception e) {
-                LOGGER.error("An error occurred while getting a bundle '{}' with locale '{}' with provider '{}'", baseName, locale, provider.getClass().getName());
+                LOGGER.warn("An error occurred while getting a bundle '{}' with locale '{}' with provider '{}'", baseName, locale, provider.getClass().getName(), e);
             }
         }
 

BotCommands-core/src/main/java/io/github/freya022/botcommands/api/utils/EmojiUtils.java

@@ -11,25 +11,25 @@
 import java.util.NoSuchElementException;
 
 /**
- * Utility class to resolve alias emojis into unicode, and getting an {@link UnicodeEmoji} out of them.
+ * Utility class to resolve alias emojis into Unicode, and getting an {@link UnicodeEmoji} out of them.
  */
 @NullMarked
 public class EmojiUtils {
     private static final int REGIONAL_INDICATOR_A_CODEPOINT = 127462;
     private static final int REGIONAL_INDICATOR_Z_CODEPOINT = 127487;
 
     /**
-     * Returns the unicode emoji from a Discord alias (e.g. {@code :joy:}).
+     * Returns the Unicode emoji from a Discord alias (e.g. {@code :joy:}).
      *
      * <p><b>Note:</b> The input string is case-sensitive!
      *
-     * <p>This will return itself if the input is a valid unicode emoji.
+     * <p>This will return itself if the input is a valid Unicode emoji.
      *
-     * @param input An emoji alias or unicode
+     * @param input An emoji alias or Unicode
      *
-     * @return The unicode string of this emoji
+     * @return The Unicode string of this emoji
      *
-     * @throws NoSuchElementException if no emoji alias or unicode matches
+     * @throws NoSuchElementException if no emoji alias or Unicode matches
      * @see #resolveJDAEmoji(String)
      */
     public static String resolveEmoji(String input) {
@@ -39,15 +39,15 @@ public static String resolveEmoji(String input) {
     }
 
     /**
-     * Returns the unicode emoji from a Discord alias (e.g. {@code :joy:}), or {@code null} if unresolvable.
+     * Returns the Unicode emoji from a Discord alias (e.g. {@code :joy:}), or {@code null} if unresolvable.
      *
      * <p><b>Note:</b> The input string is case-sensitive!
      *
-     * <p>This will return itself if the input is a valid unicode emoji.
+     * <p>This will return itself if the input is a valid Unicode emoji.
      *
-     * @param input An emoji alias or unicode
+     * @param input An emoji alias or Unicode
      *
-     * @return The unicode string of this emoji, {@code null} if unresolvable
+     * @return The Unicode string of this emoji, {@code null} if unresolvable
      *
      * @see #resolveJDAEmojiOrNull(String)
      */
@@ -85,13 +85,13 @@ private static String removeColonFromAlias(final String alias) {
      *
      * <p><b>Note:</b> The input string is case-sensitive!
      *
-     * <p>This will return itself if the input is a valid unicode emoji.
+     * <p>This will return itself if the input is a valid Unicode emoji.
      *
-     * @param input An emoji alias or unicode
+     * @param input An emoji alias or Unicode
      *
      * @return The {@link UnicodeEmoji} of this emoji
      *
-     * @throws NoSuchElementException if no emoji alias or unicode matches
+     * @throws NoSuchElementException if no emoji alias or Unicode matches
      * @see #resolveEmoji(String)
      */
     public static UnicodeEmoji resolveJDAEmoji(String input) {
@@ -103,9 +103,9 @@ public static UnicodeEmoji resolveJDAEmoji(String input) {
      *
      * <p><b>Note:</b> The input string is case-sensitive!
      *
-     * <p>This will return itself if the input is a valid unicode emoji.
+     * <p>This will return itself if the input is a valid Unicode emoji.
      *
-     * @param input An emoji alias or unicode
+     * @param input An emoji alias or Unicode
      *
      * @return The {@link UnicodeEmoji} of this emoji
      *

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/commands/annotations/Cooldown.kt

@@ -26,7 +26,7 @@ import java.time.temporal.ChronoUnit
  * alongside [RateLimiter.createDefaultProxied][RateLimiter.Companion.createDefaultProxied].
  *
  * ### Cooldown cancellation
- * The cooldown can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+ * The cooldown can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
  *
  * @see RateLimit @RateLimit
  *

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/commands/annotations/RateLimit.kt

@@ -92,7 +92,7 @@ annotation class Refill(
  * alongside [RateLimiter.Companion.createDefaultProxied].
  *
  * ### Rate limit cancellation
- * The rate limit can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+ * The rate limit can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
  *
  * ### Example
  * ```java

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/commands/builder/CommandBuilder.kt

@@ -45,7 +45,7 @@ interface CommandBuilder : INamedCommand, IDeclarationSiteHolderBuilder {
      * **Note:** This won't apply if you are a [bot owner][BotOwners.isOwner].
      *
      * ### Rate limit cancellation
-     * The rate limit can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+     * The rate limit can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
      *
      * ### Example
      *
@@ -94,7 +94,7 @@ interface CommandBuilder : INamedCommand, IDeclarationSiteHolderBuilder {
  * This cooldown cannot be referenced anywhere else as it is not registered.
  *
  * ### Cooldown cancellation
- * The cooldown can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+ * The cooldown can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
  *
  * @param duration       The duration before the cooldown expires
  * @param scope          The scope of the cooldown

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/commands/ratelimit/declaration/RateLimitManager.kt

@@ -65,7 +65,7 @@ abstract class RateLimitManager internal constructor() {
      * **Note:** The cooldown won't apply if you are a [bot owner][BotOwners.isOwner].
      *
      * ### Cooldown cancellation
-     * The cooldown can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+     * The cooldown can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
      *
      * @param group    The name of the underlying rate limiter
      * @param scope    The scope of the cooldown
@@ -96,7 +96,7 @@ abstract class RateLimitManager internal constructor() {
  * **Note:** The cooldown won't apply if you are a [bot owner][BotOwners.isOwner].
  *
  * ### Cooldown cancellation
- * The cooldown can be cancelled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
+ * The cooldown can be canceled inside the command with [CancellableRateLimit.cancelRateLimit] on your event.
  *
  * @param group          The name of the underlying rate limiter
  * @param scope          The scope of the cooldown

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/components/builder/button/ButtonFactory.kt

@@ -35,7 +35,7 @@ class ButtonFactory internal constructor(
     }
 
     /**
-     * Creates a new button factory with the provided emoji alias / emoji unicode.
+     * Creates a new button factory with the provided emoji alias / emoji Unicode.
      *
      * ### Example
      * ```kt

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/components/utils/ButtonContent.kt

@@ -88,7 +88,7 @@ data class ButtonContent(val style: ButtonStyle, val label: String?, val emoji:
         }
 
         /**
-         * Constructs a [ButtonContent] with an unicode emoji,
+         * Constructs a [ButtonContent] with a Unicode emoji,
          * see [Emoji.fromUnicode] for accepted formats.
          */
         @JvmStatic

BotCommands-core/src/main/kotlin/io/github/freya022/botcommands/api/core/reflect/ParameterType.kt

@@ -25,9 +25,7 @@ class ParameterType private constructor(val type: KType) {
 
         other as ParameterType
 
-        if (type != other.type) return false
-
-        return true
+        return type == other.type
     }
 
     override fun hashCode(): Int {