Update OpenRewrite BOM, update the status of the nested class bug

Author: freya022

build.gradle.kts

@@ -169,7 +169,7 @@ dependencies {
 
     // OpenRewrite
     // Import Rewrite's bill of materials.
-    testImplementation(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.3.0"))
+    testImplementation(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.6.1"))
 
     // rewrite-java dependencies only necessary for Java Recipe development
     testImplementation("org.openrewrite:rewrite-java")

src/main/resources/META-INF/rewrite/rewrite.yml

@@ -89,10 +89,9 @@ recipeList:
   - org.openrewrite.java.ChangeMethodName:
       methodPattern: net.dv8tion.jda.api.interactions.modals.ModalMapping getId()
       newMethodName: getCustomId
-#  Bugged due to inner classes
-#  - org.openrewrite.java.ChangeMethodName:
-#      methodPattern: net.dv8tion.jda.api.components.selects.SelectMenu.Builder getId()
-#      newMethodName: getCustomId
-#  - org.openrewrite.java.ChangeMethodName:
-#      methodPattern: net.dv8tion.jda.api.components.textinput.TextInput.Builder getId()
-#      newMethodName: getCustomId
+  - org.openrewrite.java.ChangeMethodName:
+      methodPattern: net.dv8tion.jda.api.components.selects.SelectMenu.Builder getId()
+      newMethodName: getCustomId
+  - org.openrewrite.java.ChangeMethodName:
+      methodPattern: net.dv8tion.jda.api.components.textinput.TextInput.Builder getId()
+      newMethodName: getCustomId

src/test/java/net/dv8tion/jda/test/rewrite/MigrateComponentsV2Test.java

@@ -225,8 +225,14 @@ void replacesGetId()
                 )
         );
 
-        // This is bugged, most likely due to inner classes,
-        // i've tried to switch the inner class separator from . to $, same result.
+        // Nested classes are bugged.
+        //
+        // Upgrading versions (3.3.0 -> 3.6.1) had *some* improvement,
+        // but it will still *add* an import for the nested class,
+        // even though it is already qualified starting from the already-imported top-level class.
+        //
+        // Though this will happen only if the import wasn't already present,
+        // it will still produce valid code and the user can mass optimize imports when it's finished.
 //        rewriteRun(
 //                spec -> spec.recipeFromResources("net.dv8tion.MigrateComponentsV2"),
 //                //language=java